Skip to content

Conversation

@mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Sep 8, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #33537.

How to test the changes in this Pull Request:

  1. Visit the Add new product page
  2. When hover the ? icon next to Add media button a tooltip should show like below:

image

3. When hover the ? icon next to panel with title `Product short description` a tooltip should show like below:

image

4. Every time the page is visited or refreshed the `Product short description` panel should remain collapsed by default.

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Sep 8, 2022
@mdperez86 mdperez86 requested a review from a team September 8, 2022 17:03
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Test Results Summary

Commit SHA: 2005f63

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201200m 38s
E2E Tests186001018716m 35s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mdperez86 mdperez86 force-pushed the enhancement/33537-product-creation-experince branch 3 times, most recently from 8d36bd7 to 82e627d Compare September 9, 2022 18:21
@mdperez86 mdperez86 marked this pull request as ready for review September 9, 2022 18:29
@mdperez86 mdperez86 requested a review from louwie17 September 9, 2022 18:29
}
}

#wp-content-media-buttons {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file starts from this line. Other changes were caused by the linter.

});
} );

// Add a descriptive tooltip to the product description editor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file starts from this line. Other changes were caused by the linter.

Product description editor shows a tip text that clarify the purpose of the editor
Product short description meta box title shows a tip text that clarify the purpose of the editor
@mdperez86 mdperez86 force-pushed the enhancement/33537-product-creation-experince branch from d12a165 to 9446c39 Compare September 12, 2022 14:16
@mdperez86 mdperez86 requested a review from octaedro September 12, 2022 17:10
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @mdperez86! This is testing well here and the code LGTM :shipit:
Thank you for fixing the Product data selector :-)

@mdperez86 mdperez86 merged commit 5e57471 into trunk Sep 13, 2022
@mdperez86 mdperez86 deleted the enhancement/33537-product-creation-experince branch September 13, 2022 14:23
@github-actions github-actions bot added this to the 7.0.0 milestone Sep 13, 2022
@github-actions
Copy link
Contributor

Hi @mdperez86, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@mold-man1
Copy link

Hi everyone, please reconsider collapsing the short description by default. To view the reasons why our discussion group believes this is not a good idea, please see our comments here- https://wordpress.org/support/topic/how-to-expand-short-description-by-default/

@loulemos
Copy link

Good morning, I'd like for this to be seriously considered, I have 3 clients complaining about it as it ruins their workflow. At least give us an option in Woocommerce to enable/disable by default. Since the update there have been at least 5 threads so far posted in the Woocommerce support forum and I don't think they're going to stop anytime soon. To be frank, who had this bloody ideia?

@michaeljnissen
Copy link

Thank you for the quick fix @louwie17! Just in case another debate breaks about this topic in the future, here are my two cents: I also had clients complain about this. I believe the short description is elementary especially from a customer and conversion point of view. I have several smaller customers (and this is probably a significant niche for WC) who do not use the regular description at all, but instead simply use 2-3 sentences as short description. Frankly, I would rather want to see the short description edit field be placed before the regular description. This would i) highlight the importance of the field and ii) be more concise with the position where most themes display the short description frontend-side (usually before the regular description). I just see that @pmcpinto mentioned the same suggestion/issue in the original pull request originally leading to this change.

@rinkrote
Copy link

rinkrote commented Oct 30, 2022

Hi First time github user/post here! 👋 I'd like to ask that the auto-collapsed short description be reconsidered. (edit: I now see the other github pull request that reverts! I'm happy to see that) I am a web designer and help small business owners build ecom on Woo. I use the short description on EVERY product listing AND I educate my clients on the best practice of keeping it short or highlight a few key features using a bulleted list. By having this section auto-collapsed, it adds an extra click to every product. I never knew until yesterday how inconvenient one extra click could be. Please reconsider this decision. I do love the tooltip with best practice suggestion. Maybe having the SD box be a bit smaller or having placeholder text that shows an example of highlighting 3 short bullet points. Or have some education included in a startup wizard/walkthrough? Thank you for all your hard work in developing Woo, I use it almost daily. Thanks for your time and consideration

@pmcpinto
Copy link

pmcpinto commented Nov 3, 2022

Thanks for your feedback. We'll revert this change in WooCommerce 7.2 (December)

@AnnaMag AnnaMag modified the milestones: 7.0.0, 7.2.0 Nov 3, 2022
@GlazerGallery
Copy link

michaeljnissen wrote: > Frankly, I would rather want to see the short description edit field be placed before the regular description.

I completely agree. That's the position in which it appears on the actual product page. I have never understood why the layout of the Edit Page is reversed. It makes no intuitive sense. It also is an annoying quirk since the business owner I work for writes up the info for the product pages in Word documents that we copy-paste into those fields -- a list of the main features and a short intro paragraph into the Short Description, and then the details, if there are any (and sometimes there aren't) into the long description part. I've gotten used to scrolling down to paste the Short Description info in when I open an Edit Page, and then scrolling back up, and have never liked that I had to do that. Moreover, when opening the Edit Page if there is no long description, you're greeted with a blank box on opening it. So as long as we're questioning collapsing Short Description, I think putting it at the top is a change that's long overdue for a smoother workflow. And it would also help new users if part of the goal is making this more intuitive to use.

@mold-man1
Copy link

I used to think the same thing. But I recently discovered that you can drag the short description field to the top.

@mold-man1
Copy link

Oh, and by the way, my short description field is now much taller and not collapsed by default. I modified the code in certain files. If you do not want to wait for the next WordPress update, I explained how I did that in the WordPress forum at - https://wordpress.org/support/topic/how-to-expand-short-description-by-default/. See my comments there (user name dave8441). I hope this helps.

@GlazerGallery
Copy link

Hi mold-man 1 -- you wrote > I used to think the same thing. But I recently discovered that you can drag the short description field to the top.

That does not work for me. I've tried before and I just tried again. It will not move. The closest I can get is right under the long description.

@mold-man1
Copy link

Hi @GlazerGallery ,
This might work... at the top of the edit product page, set the screen options to two columns if it isn't already. Then move the short description to the side column by clicking on the "v". Then try dragging it up. I think that is how I did it if I recall.

@GlazerGallery
Copy link

Hi @mold-man1 -- thanks for the idea, but that doesn't work for me. I do have the two-column layout enabled already, but the way the Edit Page in WooCommerce is set up, the left column takes up about 3/4 of the width, and having the Short Description squished into that narrow column on the right doesn't work for me. I just want it directly above the long description.

@mold-man1
Copy link

I meant to say, after you put it in the narrow column, do not leave it there, but then try to drag it from there to directly above the long description. After you do that, the width of the short description will automatically widen to the same width as the long description.

@GlazerGallery
Copy link

Hi @mold-man1 -- No, that does not work for me. I can put it in the narrow column, but cannot move it back to the wide column above the long description. The closest I can get is right under the long description.

@mold-man1
Copy link

Sorry that did not work for you. You may want to post the issue at https://wordpress.org/support/plugin/woocommerce/ and perhaps the plugin authors can help.

@myedgy
Copy link

myedgy commented Dec 7, 2022

Please revert this! Super annoying to reopen the 'short description field' each time, its just an extra click. And it's small thay i always scroll over it to find it.. It's just an extra step.

If you don't want to see this field. Drag it to the bottom of your dashboard panel.

Please revert this, thank you.

@pmcpinto
Copy link

pmcpinto commented Dec 9, 2022

This change will be reverted in WooCommerce 7.2: #35213

@mold-man1
Copy link

mold-man1 commented Apr 29, 2025 via email

@mold-man1
Copy link

mold-man1 commented Apr 29, 2025 via email

@mold-man1
Copy link

mold-man1 commented Apr 29, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Product creation experience: no clear distinction between long and short description