Skip to content

Conversation

@rjchow
Copy link
Contributor

@rjchow rjchow commented Sep 8, 2022

All Submissions:

Changes proposed in this Pull Request:

p1662617142524119-slack-C01SFMVEYAK

It was noticed that if the user completes the onboarding profiler without filling in their address details (which are not mandatory anymore since #34176) then the shipping smart defaults flow would not kick in.

How to test the changes in this Pull Request:

  1. Go to OBW
  2. Select a "Country", but NOT fill the "Address"
  3. Complete the rest of OBW with "physical products" and any other required details
  4. Upon completing the OBW you should notice that there is a item to "Review Shipping Details" and clicking on it should bring you to the shipping settings page which should have a free shipping default filled in.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Sep 8, 2022
@rjchow rjchow requested a review from a team September 8, 2022 08:27
@rjchow rjchow marked this pull request as ready for review September 8, 2022 08:27
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Test Results Summary

Commit SHA: f3e7184

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201200m 43s
E2E Tests186001018713m 10s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested well! 🚢

@rjchow rjchow merged commit d191ecc into trunk Sep 12, 2022
@rjchow rjchow deleted the fix/shipping-defaults-when-address-not-set branch September 12, 2022 03:46
@github-actions github-actions bot added this to the 7.0.0 milestone Sep 12, 2022
@github-actions
Copy link
Contributor

Hi @rjchow, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants