Skip to content

Conversation

@mattsherman
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR fixes the helper text shown below the list price field to reflect whether taxes are to be included in the price or not.

Follow up to #34382

How to test the changes in this Pull Request:

  1. Go to Products > Add New (MVP) and create a product.
  2. If tax is included in the price, the helper text reads: "Per your store settings, tax is included in the price."
  3. If tax is excluded from the price, the helper text reads: "Per your store settings, tax is not included in the price."
  4. Verify that clicking "store settings" in the label below the list price takes you to wp-admin/admin.php?page=wc-settings&tab=tax
  5. Verify that clicking "store settings" fires the wcadmin_product_pricing_list_price_help_tax_settings_click Tracks event

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Test Results Summary

Commit SHA: 7999ed9

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201200m 54s
E2E Tests186001018718m 6s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

louwie17
louwie17 previously approved these changes Sep 6, 2022
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this logic @mattsherman, this tested well, and code changes look good.

@mattsherman mattsherman force-pushed the fix/products-pricing-tax-included-label branch from 56c6609 to bfbda4b Compare September 6, 2022 16:51
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Sep 6, 2022
@mattsherman mattsherman force-pushed the fix/products-pricing-tax-included-label branch from bfbda4b to 7999ed9 Compare September 6, 2022 18:22
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after rebase to get Github actions passing.

@mattsherman mattsherman merged commit beb6a6f into trunk Sep 7, 2022
@mattsherman mattsherman deleted the fix/products-pricing-tax-included-label branch September 7, 2022 13:33
@github-actions github-actions bot added this to the 7.0.0 milestone Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Hi @mattsherman, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants