Products pricing section code cleanup #34560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results SummaryCommit SHA: 51f7542
To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
louwie17
previously approved these changes
Sep 2, 2022
Contributor
louwie17
left a comment
louwie17
left a comment
There was a problem hiding this comment.
LGTM 🚀 nice work @mattsherman, thanks for keeping it small and not including it as part of other work ( I have something to learn from you :) )
Also appreciate not seeing the giant deprecated warning in the console anymore 👍 👍
octaedro
reviewed
Sep 2, 2022
Comment on lines
66
to
70
| const taxSettingsText = | ||
| 'Per your {{link}}store settings{{/link}}, tax is {{strong}}%sincluded{{/strong}} in the price.'; | ||
| const addNot = pricesIncludeTax ? '' : 'not '; | ||
| taxSettingsText.replace( taxSettingsText, addNot ); | ||
|
|
Contributor
There was a problem hiding this comment.
We will need the addNot to add it when the tax is not included in the price (37-gh-woocommerce/mothra-private).
The code should look like this:
const addNot = pricesIncludeTax ? '' : 'not ';
const taxSettingsElement = interpolateComponents( {
mixedString: sprintf(
__(
'Per your {{link}}store settings{{/link}}, tax is {{strong}}%sincluded{{/strong}} in the price.',
'woocommerce'
),
addNot
),
components: {
link: (
<Link
href={ `${ ADMIN_URL }admin.php?page=wc-settings&tab=tax` }
target="_blank"
type="external"
onClick={ () => {
recordEvent( 'product_pricing_list_price_help' );
} }
>
<></>
</Link>
),
strong: <strong />,
},
} );
I missed that in my original PR.
octaedro
reviewed
Sep 2, 2022
Contributor
octaedro
left a comment
octaedro
left a comment
There was a problem hiding this comment.
Good job @mattsherman! The code looks good and other than the comment I left this is testing well on my end.
mattsherman
force-pushed
the
update/products-pricing-section-cleanup
branch
from
fcddacb to
51f7542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR addresses a few code issues in the products pricing section:
Removes a bit of unused codeCurrency().formatCurrency, which is deprecated, toCurrency().formatAmountpriceValidationtosanitizeAndSetPrice, which is more accurate (it was not validating the price, but rather sanitizing it and then setting it) and swaps the order of thenameandvalue, which is more natural (name, value vs value, name)This is a follow up to #34382
How to test the changes in this Pull Request:
Products>Add New (MVPand create a product.Other information:
pnpm changelog add --filter=<project>?FOR PR REVIEWER ONLY: