Skip to content

Update/34540 add walmart and wish to store list #34541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moon0326 merged 2 commits into from
Sep 1, 2022
Merged

Update/34540 add walmart and wish to store list #34541

moon0326 merged 2 commits into from
Sep 1, 2022

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Sep 1, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #34540 .

How to test the changes in this Pull Request:

  1. Start with a fresh site.
  2. Start OBW.
  3. On the Business Details step, choose Yes, on another latform for Currently selling elsewhere?.
  4. Confirm Wish and Walmart are listed under Which platform is the store using?

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Sep 1, 2022
@moon0326 moon0326 requested a review from a team September 1, 2022 01:13
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Test Results Summary

Commit SHA: 1f26363

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201200m 52s
E2E Tests186001018713m 29s
 To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

chihsuan
chihsuan approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm Wish and Walmart are listed. Looks good! 👍

@moon0326 moon0326 merged commit b4b7b4c into trunk Sep 1, 2022
@moon0326 moon0326 deleted the update/34540-add-walmart-and-wish-to-store-list branch September 1, 2022 16:11
@github-actions github-actions bot added this to the 7.0.0 milestone Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Hi @moon0326, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Add Walmart and Wish to Onboarding

3 participants

@moon0326 @chihsuan