Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Aug 26, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #34460.

This PR adds a new value is_store_country_set to profiler items to check if store country is set via onboarding profiler to fix the issue.

How to test the changes in this Pull Request:

  1. Go to OBW
  2. Select a "Country", but NOT fill the "Address"
  3. Click Continue and go to the next step
  4. Click on (1) Store Details in the header
  5. Observe that the Country field is filled

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Aug 26, 2022
@chihsuan chihsuan force-pushed the fix/34460-country-field-is-empty-when-navigating-back branch from 8223d31 to aa2e613 Compare August 26, 2022 06:05
@chihsuan chihsuan marked this pull request as ready for review August 26, 2022 06:07
@chihsuan chihsuan self-assigned this Aug 26, 2022
@chihsuan chihsuan requested a review from a team August 26, 2022 06:21
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: aa2e613

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests000000NaNm NaNs
E2E Tests186001018714m 23s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests well according to instructions and fixes the bug 🚀

@chihsuan chihsuan merged commit f813153 into trunk Aug 30, 2022
@chihsuan chihsuan deleted the fix/34460-country-field-is-empty-when-navigating-back branch August 30, 2022 01:44
@github-actions github-actions bot added this to the 7.0.0 milestone Aug 30, 2022
@github-actions
Copy link
Contributor

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Country field is empty when navigating back to "Store Details" tab

3 participants