Skip to content

Hide finish setup button when task list is disabled #34410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 3 commits into from
Aug 24, 2022
Merged

Hide finish setup button when task list is disabled #34410

chihsuan merged 3 commits into from
Aug 24, 2022

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Aug 22, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #34143.

The setup button is still shown when the task list is disabled. This PR fixes the wrong logic of isSetupTaskListHidden.

How to test the changes in this Pull Request:

  1. Make sure the task list has not been completed or use a fresh installation
  2. Go to WooCommerce > Settings > Help > Setup Wizard
  3. Click Disable under Task List
  4. Go to WooCommerce > Orders
  5. Observe that Finish Setup button is not shown on the right of the header bar

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Aug 22, 2022
@chihsuan chihsuan marked this pull request as ready for review August 22, 2022 00:34
@chihsuan chihsuan self-assigned this Aug 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2022 •
edited
Loading

Test Results Summary

Commit SHA: 7775abf

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201200m 39s
E2E Tests186001018713m 47s
 To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@chihsuan chihsuan requested a review from a team August 23, 2022 02:31
ilyasfoo
ilyasfoo suggested changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well but a nitpicky comment:

@ilyasfoo ilyasfoo self-requested a review August 23, 2022 08:55
ilyasfoo
ilyasfoo approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! :shipit:

@chihsuan chihsuan merged commit 467b5db into trunk Aug 24, 2022
@chihsuan chihsuan deleted the fix/34143-hide-finish-setup-button-when-task-list-is-disabled branch August 24, 2022 01:39
@github-actions github-actions bot added this to the 7.0.0 milestone Aug 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2022

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ilyasfoo ilyasfoo ilyasfoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Disabling set up task list results in empty "Finish Setup" popout

3 participants

@chihsuan @ilyasfoo