Skip to content

Fix unusable historical import #34054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilyasfoo merged 2 commits into from
Jul 25, 2022
Merged

Fix unusable historical import #34054

ilyasfoo merged 2 commits into from
Jul 25, 2022

Conversation

@ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented Jul 25, 2022

Changes proposed in this Pull Request:

Closes #34048

Fix missing resolver import for data package import module

How to test the changes in this Pull Request:

  1. Go to Analytics -> Settings
  2. Open browser inspector
  3. Refresh
  4. Observe request to /reports/import/totals

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@ilyasfoo ilyasfoo requested a review from a team July 25, 2022 01:44
@github-actions github-actions bot added package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022

Test Results Summary

Commit SHA: 6d43088

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11500201170m 39s
E2E Tests185001018614m 16s
 To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

rjchow
rjchow approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@rjchow rjchow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, fixes the bug! But I think the testing instructions probably need a bit more detail

  1. Install WooCommerce, generate some products and orders using Smooth Generator
  2. Go to WooCommerce > Analytics > Settings
  3. Open developer console, network tab
  4. Back to the browser in Analytics Settings, uncheck "Skip previously imported customers and orders"
  5. Observe that the network call is made and that the number of registered customers / orders update below
  6. Observe that the network call to wc-analytics/reports/imports/totals has been made by looking for the entry totals?_locale=user in the network tab (see screenshot)
  7. Observe that "Start" import button is now enabled

image

@ilyasfoo
Copy link
Contributor Author

ilyasfoo commented Jul 25, 2022

Thanks for the more in-depth testing instructions!

@ilyasfoo ilyasfoo merged commit e41c8b0 into trunk Jul 25, 2022
@ilyasfoo ilyasfoo deleted the fix/34048-historical-import-unusable branch July 25, 2022 03:20
@github-actions github-actions bot added this to the 6.9.0 milestone Jul 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022

Hi @ilyasfoo, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@ilyasfoo ilyasfoo modified the milestones: 6.9.0, 6.8.0 Jul 25, 2022
@psealock psealock mentioned this pull request Jul 26, 2022
Merged
psealock pushed a commit that referenced this pull request Jul 26, 2022
@ilyasfoo @psealock
Fix unusable historical import (#34054)
a144d1d 
* Add resolvers to data store

* Changelog
psealock added a commit that referenced this pull request Jul 26, 2022
@psealock @ilyasfoo
Prep for cherry pick 34054 (#34061)
f0d5d96 
* Fix unusable historical import (#34054)

* Add resolvers to data store

* Changelog

* Prep for cherry pick 34054

Co-authored-by: Ilyas Foo <[email protected]>
jacob-sewell pushed a commit that referenced this pull request Jul 29, 2022
@ilyasfoo @jacob-sewell
Fix unusable historical import (#34054)
40c3c46 
* Add resolvers to data store

* Changelog
@nicdwilson nicdwilson mentioned this pull request Aug 6, 2022
Closed
5 tasks
@github-actions github-actions bot mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rjchow rjchow rjchow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.8.0

Development

Successfully merging this pull request may close these issues.

[6.7.0] Import historical data tool not usable - 'Start' always disabled and 'Delete previously imported data' missing even if data exists.

3 participants

@ilyasfoo @rjchow