Skip to content

Fix fatal error when bulk editing sale price to empty value in PHP 8 #34053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Konamiman merged 3 commits into from
Jul 28, 2022
Merged

Fix fatal error when bulk editing sale price to empty value in PHP 8 #34053

Konamiman merged 3 commits into from
Jul 28, 2022

Conversation

@daniyalahmadk
Copy link
Contributor

@daniyalahmadk daniyalahmadk commented Jul 24, 2022 •
edited by Konamiman
Loading

#31947 fixed the issue by type casting from string to float.

All Submissions:

Changes proposed in this Pull Request:

Closes #31947.

How to test the changes in this Pull Request:

Under PHP 8 follow the testing instructions of #31947.

Other information:

  • [ x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x ] Have you written new tests for your changes, as applicable?
  • [ x] Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@daniyalahmadk
Update class-wx-admin-post-types.php
5d61fad 
woocommerce#31947 fixed the issue by type casting from string to float.
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 24, 2022
@daniyalahmadk daniyalahmadk requested a review from Konamiman July 24, 2022 14:27
daniyalahmadk and others added 2 commits July 26, 2022 13:53
@Konamiman Konamiman changed the title Update class-wx-admin-post-types.php Fix fatal error when bulk editing sale price to empty value in PHP 8 Jul 28, 2022
@Konamiman Konamiman merged commit 94cc85b into woocommerce:trunk Jul 28, 2022
@github-actions github-actions bot added this to the 6.9.0 milestone Jul 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2022

Hi @Konamiman, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

jacob-sewell pushed a commit that referenced this pull request Jul 29, 2022
@daniyalahmadk @jacob-sewell
Fix fatal error when bulk editing sale price to empty value in PHP 8 (#…
11db81c 
…34053)
@Konamiman Konamiman added the release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Konamiman Konamiman Konamiman approved these changes

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto]

Projects

None yet

Milestone

6.9.0

Development

Successfully merging this pull request may close these issues.

Fatal error when saving a bulk edit when set Set to regular price decreased by (fixed amount or %): as empty

2 participants

@daniyalahmadk @Konamiman