Skip to content

Fix Tracks event in Review Shipping task #34045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adrianduffell merged 2 commits into from
Jul 28, 2022
Merged

Fix Tracks event in Review Shipping task #34045

adrianduffell merged 2 commits into from
Jul 28, 2022

Conversation

@adrianduffell
Copy link
Contributor

@adrianduffell adrianduffell commented Jul 22, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #33994 .

This change ensures the correct task list is populated in the Tracks event when the "Review Shipping Options" task is completed.

How to test the changes in this Pull Request:

With a new store,

  1. Select United States as a country.
  2. Continue through the onboarding wizard without installing free business features.
  3. On the "Things to do next" task list, choose "Review Shipping Options".
  4. Complete the spotlight tour on the settings page..
  5. Navigate to WooCommerce > Home
  6. See that the "Review Shipping Options" task is completed.7.
  7. Navigate to WooCommercer > Status > Logs
  8. Choose the Tracks log for the current date.
  9. Confirm the Tracks event is in the log:
2022-07-27T13:47:15+00:00 DEBUG wcadmin_extended_tasklist_task_completed
2022-07-27T13:47:15+00:00 DEBUG   - task_name: review-shipping

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 22, 2022
@adrianduffell adrianduffell force-pushed the fix/review-shipping-track branch 2 times, most recently from 4a58d15 to 4d9d4b1 Compare July 22, 2022 14:13
@adrianduffell adrianduffell changed the title Fix track in Review Shipping task Fix Tracks event in Review Shipping task Jul 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022 •
edited
Loading

Test Results Summary

Commit SHA: cfcdb42

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11500201170m 54s
E2E Tests185001018614m 34s
 To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@adrianduffell adrianduffell marked this pull request as ready for review July 27, 2022 14:00
@adrianduffell adrianduffell requested a review from a team July 27, 2022 14:01
@adrianduffell adrianduffell force-pushed the fix/review-shipping-track branch from 4d9d4b1 to cfcdb42 Compare July 28, 2022 03:55
moon0326
moon0326 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this fix @adrianduffell

LGTM and tested well 🚀 👍

@adrianduffell
Copy link
Contributor Author

adrianduffell commented Jul 28, 2022

@ilyasfoo Your idea to fix this worked well ❤️

@adrianduffell adrianduffell merged commit 50421ef into trunk Jul 28, 2022
@adrianduffell adrianduffell deleted the fix/review-shipping-track branch July 28, 2022 04:21
@github-actions github-actions bot added this to the 6.9.0 milestone Jul 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2022

Hi @adrianduffell, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@psealock psealock mentioned this pull request Jul 28, 2022
Merged
psealock pushed a commit that referenced this pull request Jul 28, 2022
@adrianduffell @psealock
Fix Tracks event in Review Shipping task (#34045)
5c183ac
psealock added a commit that referenced this pull request Jul 28, 2022
@psealock @adrianduffell
Prep for cherry pick 34045 (#34093)
4dc69aa 
* Fix Tracks event in Review Shipping task (#34045)

* Prep for cherry pick 34045

Co-authored-by: Adrian Duffell <[email protected]>
jacob-sewell pushed a commit that referenced this pull request Jul 29, 2022
@adrianduffell @jacob-sewell
Fix Tracks event in Review Shipping task (#34045)
11f9235
@github-actions github-actions bot mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@moon0326 moon0326 moon0326 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.9.0

Development

Successfully merging this pull request may close these issues.

Shipping recommendation task track uses a different track name

3 participants

@adrianduffell @moon0326