Skip to content

Conversation

@albarin
Copy link
Contributor

@albarin albarin commented Jul 21, 2022

All Submissions:

Changes proposed in this Pull Request:

This PR makes sure that when a block theme is active, activating WooCommerce core will not enable the Customizer option from the Appearance settings section and the Customize button from the WP admin

For more context see: https://woofse.wordpress.com/2022/06/07/pt-ensure-customizer-doesnt-show-up-with-block-themes-active-2/

How to test the changes in this Pull Request:

  1. Enable WooCommerce.
  2. Enable the Storefront theme.
  3. Check that the Customize button appears on the Appearance menu and on the menu bar.
  4. Enable a block theme (i.e. Twentytwentytwo).
  5. Check that the Customize button does not show up on the Appearance menu or on the menu bar.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 21, 2022
@albarin albarin changed the title Only register the customizer and related scripts when the active theme is a classic one Hide the customizer when the active theme is a FSE theme Jul 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2022

Test Results Summary

Commit SHA: 2146878

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11500201170m 39s
E2E Tests185001018612m 17s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@albarin albarin force-pushed the hide-customiser-for-fse-themes branch 2 times, most recently from 3676e23 to a48e7bb Compare July 22, 2022 12:37
@albarin albarin marked this pull request as ready for review July 22, 2022 13:56
@albarin albarin removed the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 22, 2022
@albarin albarin requested review from a team and barryhughes and removed request for a team July 22, 2022 14:17
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Aug 4, 2022
@albarin albarin requested a review from barryhughes August 4, 2022 09:46
@barryhughes barryhughes force-pushed the hide-customiser-for-fse-themes branch from 6b92b3e to 2146878 Compare August 4, 2022 15:46
@barryhughes barryhughes merged commit 4a4de7a into trunk Aug 4, 2022
@barryhughes barryhughes deleted the hide-customiser-for-fse-themes branch August 4, 2022 16:57
@github-actions github-actions bot added this to the 6.9.0 milestone Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants