-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Hide the customizer when the active theme is a FSE theme #34022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results SummaryCommit SHA: 2146878
To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
3676e23 to
a48e7bb
Compare
barryhughes
requested changes
Aug 3, 2022
plugins/woocommerce/includes/customizer/class-wc-shop-customizer.php
Outdated
Show resolved
Hide resolved
6b92b3e to
2146878
Compare
barryhughes
approved these changes
Aug 4, 2022
Contributor
|
Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
This was referenced Aug 18, 2022
5 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR makes sure that when a block theme is active, activating WooCommerce core will not enable the
Customizeroption from the Appearance settings section and theCustomizebutton from the WP adminFor more context see: https://woofse.wordpress.com/2022/06/07/pt-ensure-customizer-doesnt-show-up-with-block-themes-active-2/
How to test the changes in this Pull Request:
WooCommerce.Storefronttheme.Customizebutton appears on theAppearancemenu and on the menu bar.Twentytwentytwo).Customizebutton does not show up on theAppearancemenu or on the menu bar.Other information:
pnpm changelog add --filter=<project>?FOR PR REVIEWER ONLY: