Fix inconsistent order total on checkout vs manual order page #33812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods are moved to separate classes in src/Internal, and two new "core" methods that exclude HTTP processing are added.
github-actions
bot
added
the
plugin: woocommerce
Contributor
Test Results SummaryCommit SHA: fbfbd6f
To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Konamiman
changed the title
Konamiman
requested review from
a team and
vedanshujain
and removed request for
a team
Contributor
|
@vedanshujain checking in to see if you've got any code review feedback on this PR (as it will help unblock some downstream work in the EU VAT extension)? |
Contributor
|
Hi @vedanshujain, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
7 tasks
vedanshujain
pushed a commit
that referenced
this pull request
Aug 18, 2022
* fix: tax calculation and coupon sequence * add phpunit skeleton * Refactor calc_line_taxes and add_coupon_discount The methods are moved to separate classes in src/Internal, and two new "core" methods that exclude HTTP processing are added. * The test partially passes now * Final fix to unit tests, and fix remaining formatting issues * Add changelog file * Fix path to html-order-items.php Co-authored-by: Siddharth Thevaril <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes inconsistent order total on checkout vs manual order page when the shop is configured for tax-inclusive prices and a coupon is applied. Also refactors the
add_coupon_discountandcalc_line_taxesmethods in theWC_AJAXclass to make the code more unit testable.Fix originally submitted by @Sidsector9 in #32010, work redone in a new pull request in order to easily apply ther required refactoring.
Note for reviewers: It's obscured by the refactor, but the main change in this pull request is executing
$order->calculate_taxesand$order->calculate_totalsbefore$order->apply_coupon, instead of after, insideadd_coupon_discount.Closes #31971.
How to test the changes in this Pull Request:
See #31971 and #32010
Other information:
pnpm changelog add --filter=<project>?FOR PR REVIEWER ONLY: