Skip to content

Added the border bottom of the modal's header #33807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 3 commits into from
Jul 15, 2022
Merged

Added the border bottom of the modal's header #33807

chihsuan merged 3 commits into from
Jul 15, 2022

Conversation

@aezazs-multidots
Copy link
Contributor

@aezazs-multidots aezazs-multidots commented Jul 11, 2022 •
edited by chihsuan
Loading

All Submissions:

Changes proposed in this Pull Request:

I have fixed the border-bottom not coming in the header of the component modal.

Closes #33720

Steps to reproduce:

  1. Use a fresh site
  2. Go to OBW
  3. Fill out store details
  4. Click "Continue"
  5. Observer that the Build a better WooCommerce modal's header contains a bottom border

Screen Shot 2022-07-15 at 14 34 22

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 11, 2022
@psealock psealock requested a review from louwie17 July 12, 2022 02:02
chihsuan
chihsuan reviewed Jul 15, 2022
View reviewed changes
plugins/woocommerce/changelog/added-modal-border-bottom Outdated
Significance: minor
Type: enhancement

Fixed 33720 - I have fixed the border-bottom not coming in the header of the component modal. No newline at end of file
Copy link
Member

@chihsuan chihsuan Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion ⬇️

Suggested change
Fixed 33720 - I have fixed the border-bottom not coming in the header of the component modal.
Add the border bottom of the modal's header

@chihsuan
Copy link
Member

chihsuan commented Jul 15, 2022

@aezazs-multidots Could you also add test instructions for this PR? Thanks!

@aezazs-multidots
Copy link
Contributor Author

aezazs-multidots commented Jul 15, 2022 •
edited
Loading

Hello @chihsuan

I have added the steps of How to test the changes in this Pull Request: in this PR. also I have done what you asked to change in the changelog entry.

Please let me know if you have any queries about the same.

Thanks & Regards

chihsuan
chihsuan approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chihsuan chihsuan merged commit 0cbaab7 into woocommerce:trunk Jul 15, 2022
@github-actions github-actions bot added this to the 6.9.0 milestone Jul 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

lanej0 pushed a commit that referenced this pull request Jul 15, 2022
@aezazs-multidots
Added the border bottom of the modal's header (#33807)
559daa9 
* Added the border bottom of the modal's header

* Created changelog entry

* Changelog entry update
@jonathansadowski jonathansadowski mentioned this pull request Jul 15, 2022
Closed
jonathansadowski pushed a commit that referenced this pull request Jul 15, 2022
@aezazs-multidots
Added the border bottom of the modal's header (#33807)
b3cdba7 
* Added the border bottom of the modal's header

* Created changelog entry

* Changelog entry update
@github-actions github-actions bot mentioned this pull request Sep 14, 2022
Closed
@mikkamp mikkamp mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

@louwie17 louwie17 Awaiting requested review from louwie17

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.9.0

Development

Successfully merging this pull request may close these issues.

Modal header border bottom is missing

2 participants

@aezazs-multidots @chihsuan