Skip to content

Update WooCommerce Blocks package to 7.8.3 #33514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorgeatorres merged 1 commit into from
Jun 20, 2022
Merged

Update WooCommerce Blocks package to 7.8.3 #33514

jorgeatorres merged 1 commit into from
Jun 20, 2022

Conversation

@gigitux
Copy link
Contributor

@gigitux gigitux commented Jun 20, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

This pull updates the WooCommerce Blocks plugin to 7.8.3 to fix a PHP fatal in the Product Search Results template affecting all stores in WP 5.8 (woocommerce/woocommerce-blocks#6590). It also includes a fix to a PHP warning in the Mini Cart in certain circumstances (woocommerce/woocommerce-blocks#6537).

Details from the released version

Blocks 7.8.2

Blocks 7.8.3

Changelog entry

The following changelog entries are only those that impact existing blocks and functionality surfaced to users:

Bug Fixes

  • Fix images hidden by default in Product grid blocks after WC 6.6 update. (6599)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@gigitux gigitux force-pushed the update/woocommerce-blocks-7.8.2 branch from c218f0a to 26d1035 Compare June 20, 2022 09:10
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 20, 2022
@gigitux gigitux force-pushed the update/woocommerce-blocks-7.8.2 branch 2 times, most recently from b3e8722 to 752ba7e Compare June 20, 2022 09:23
@gigitux gigitux requested review from a team and jorgeatorres and removed request for a team June 20, 2022 09:28
@botwoo
Copy link
Collaborator

botwoo commented Jun 20, 2022 •
edited
Loading

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Update WooCommerce Blocks package to 7.8.3 8c0bcf2
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

jorgeatorres
jorgeatorres requested changes Jun 20, 2022
View reviewed changes
Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team!

Shouldn't the Blocks version in composer.json be bumped too?

@jorgeatorres jorgeatorres added the needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. label Jun 20, 2022
@gigitux gigitux force-pushed the update/woocommerce-blocks-7.8.2 branch from 752ba7e to 8c0bcf2 Compare June 20, 2022 13:28
@gigitux gigitux changed the title Update WooCommerce Blocks package to 7.8.2 Update WooCommerce Blocks package to 7.8.3 Jun 20, 2022
@gigitux
Copy link
Contributor Author

gigitux commented Jun 20, 2022

Hi team!

Shouldn't the Blocks version in composer.json be bumped too?

Thanks for the review! I forgot to add it :/

Users report another issue and we released version 7.8.3. I updated this PR, in this way WC Core 6.7 will contain the version 7.8.3.

@gigitux gigitux requested a review from jorgeatorres June 20, 2022 13:37
@github-actions github-actions bot added needs: triage feedback Issues for which we requested feedback from the author and received it. and removed needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. labels Jun 20, 2022
jorgeatorres
jorgeatorres approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gigitux!

@jorgeatorres jorgeatorres merged commit a53b44f into trunk Jun 20, 2022
@jorgeatorres jorgeatorres deleted the update/woocommerce-blocks-7.8.2 branch June 20, 2022 19:34
@github-actions github-actions bot added this to the 6.8.0 milestone Jun 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2022

Hi @jorgeatorres, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@ObliviousHarmony ObliviousHarmony modified the milestones: 6.8.0, 6.7.0 Jun 28, 2022
@ObliviousHarmony ObliviousHarmony added release: cherry-pick Commits from this PR also needs to be added to current release branch. and removed needs: triage feedback Issues for which we requested feedback from the author and received it. labels Jun 28, 2022
ObliviousHarmony pushed a commit that referenced this pull request Jun 28, 2022
@gigitux @ObliviousHarmony
Update WooCommerce Blocks package to 7.8.3 (#33514)
9552c3b
@ObliviousHarmony ObliviousHarmony mentioned this pull request Jun 28, 2022
Merged
@ObliviousHarmony ObliviousHarmony removed the release: cherry-pick Commits from this PR also needs to be added to current release branch. label Jun 28, 2022
ObliviousHarmony added a commit that referenced this pull request Jun 28, 2022
@ObliviousHarmony @gigitux
@joshuatf @rjchow
Prepare WooCommerce 6.7 Beta.2 (#33642)
05fadd3 
* Update WooCommerce Blocks package to 7.8.3 (#33514)

* Move tracks _ui and _ut properties out of filtered tracks properties (#33621)

* Move tracks _ui and _ut properties out of filtered tracks properties

* Add tests around tracks properties

* Fix broken variable name

* Add changelog entry

* Fix payments settings banner experiment logic (#33549)

* Delegate payment experiment logic into its own hook and rearrange the checking logic to be before the experiment is called

* Changelog

* fix payments banner experiment test (#33589)

test needed to be updated as the component did not call useExperiment directly anymore

* Prepared Changelog

* Removed Changelog Files

* Updated Version

Co-authored-by: Luigi Teschio <[email protected]>
Co-authored-by: Joshua T Flowers <[email protected]>
Co-authored-by: RJ <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgeatorres jorgeatorres jorgeatorres approved these changes

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@gigitux @botwoo @jorgeatorres @ObliviousHarmony