Skip to content

Update product task experiment names #33428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilyasfoo merged 3 commits into from
Jun 15, 2022
Merged

Update product task experiment names #33428

ilyasfoo merged 3 commits into from
Jun 15, 2022

Conversation

@ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented Jun 15, 2022 •
edited
Loading

Changes proposed in this Pull Request:

This PR updates product task experiment names due to the previous experiment had to be cancelled.

How to test the changes in this Pull Request:

Test using WCA Test helper

  1. Install and activate the latest WooCommerce Test Helper plugin
  2. Navigate to Tools > WCA Test Helper > Experiments and add woocommerce_products_task_layout_card_v2 to treatment
  3. Make sure your site has woocommerce_allow_tracking option set to yes
  4. Go to WooCommerce > Home > Add my products
  5. Observe the experiment card screen

Test using bookmarklet

  1. Navigate to Tools > WCA Test Helper > Experiments and delete woocommerce_products_task_layout_card_v2 from treatment
  2. Apply woocommerce_products_task_layout_stacked_v2 treatment bookmarklet
  3. Go to WooCommerce > Home > Add my products
  4. Observe the experiment stacked screen

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@ilyasfoo ilyasfoo requested a review from a team June 15, 2022 02:58
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 15, 2022
@botwoo
Copy link
Collaborator

botwoo commented Jun 15, 2022 •
edited
Loading

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Fix lint 990d44c
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

chihsuan
chihsuan previously approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating them! Looks good and tested well.

@chihsuan
Copy link
Member

chihsuan commented Jun 15, 2022 •
edited
Loading

Looks like lint ci failed.

@woocommerce/admin-library:lint:   12:28  error  Replace `·`woocommerce_products_task_layout_stacked_v2`·` with `⏎↹↹↹`woocommerce_products_task_layout_stacked_v2`⏎↹↹`  prettier/prettier
@woocommerce/admin-library:lint:

@ilyasfoo ilyasfoo requested a review from chihsuan June 15, 2022 07:06
@ilyasfoo
Copy link
Contributor Author

ilyasfoo commented Jun 15, 2022

Thanks for catching that, @chihsuan! I've made the lint fix. The PHP error is not related afaik

@ilyasfoo ilyasfoo merged commit 090822e into trunk Jun 15, 2022
@ilyasfoo ilyasfoo deleted the tweak/update-product-task-experiment-names branch June 15, 2022 08:34
@github-actions github-actions bot added this to the 6.7.0 milestone Jun 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

Hi @ilyasfoo, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ilyasfoo @botwoo @chihsuan