Skip to content

Update product template descriptions #33397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 2 commits into from
Jun 14, 2022
Merged

Update product template descriptions #33397

chihsuan merged 2 commits into from
Jun 14, 2022

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Jun 13, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #33380.

This PR replaces the "Pellentesque habitant.." product descriptions in the product templates with more realistic examples.

How to test the changes in this Pull Request:

  1. Go to add my products
  2. Click Start with a template
  3. Choose Physical product
  4. Observe that the Hoodie in sweatshirt fabric made from a cotton blend. text is shown in the product description.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 13, 2022
@chihsuan chihsuan marked this pull request as ready for review June 13, 2022 04:07
@chihsuan chihsuan self-assigned this Jun 13, 2022
@chihsuan chihsuan requested a review from a team June 13, 2022 04:12
@botwoo
Copy link
Collaborator

botwoo commented Jun 13, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Add changelog 2c6cce1
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

moon0326
moon0326 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well! 👍 🚀

@chihsuan chihsuan merged commit 257e558 into trunk Jun 14, 2022
@chihsuan chihsuan deleted the update/product-template-descriptions branch June 14, 2022 02:22
@github-actions github-actions bot added this to the 6.7.0 milestone Jun 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2022

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@moon0326 moon0326 moon0326 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.7.0

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Replace "lorem ipsum" texts in product templates

4 participants

@chihsuan @botwoo @moon0326