Skip to content

Fix continue button is enabled when email is null in setup wizard #33362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 2 commits into from
Jun 10, 2022
Merged

Fix continue button is enabled when email is null in setup wizard #33362

chihsuan merged 2 commits into from
Jun 10, 2022

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Jun 9, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #32588.

This PR fixes the issue such that if the newsletter signup checkbox is checked AND the email text box is empty, we disable the Continue button.

How to test the changes in this Pull Request:

  1. Go to the Setup Wizard
  2. Fill in details like Address, Country, City, and Postcode
  3. Check the Get tips, product updates and inspiration straight to your mailbox. checkbox
  4. Ensure the email textbox is empty
  5. Observe that "Please enter your email address to subscribe" error is displayed, and "Continue" button is disabled.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 9, 2022
@chihsuan chihsuan self-assigned this Jun 9, 2022
@chihsuan chihsuan marked this pull request as ready for review June 9, 2022 06:59
@chihsuan chihsuan requested a review from a team June 9, 2022 06:59
@botwoo
Copy link
Collaborator

botwoo commented Jun 9, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Add changelog 6b69afc
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

ilyasfoo
ilyasfoo approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, LGTM! 🚢

@chihsuan chihsuan merged commit 558e5e3 into trunk Jun 10, 2022
@chihsuan chihsuan deleted the fix/32588-continue-button-is-enabled-when-email-is-null branch June 10, 2022 02:35
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2022 •
edited by chihsuan
Loading

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot added this to the 6.7.0 milestone Jun 10, 2022
@chihsuan chihsuan added the release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ilyasfoo ilyasfoo ilyasfoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto]

Projects

None yet

Milestone

6.7.0

Development

Successfully merging this pull request may close these issues.

Setup Wizard Store details page, continue button is enabled even when email is null

4 participants

@chihsuan @botwoo @ilyasfoo