Skip to content

Conversation

@Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jun 3, 2022

All Submissions:

Changes proposed in this Pull Request:

Add overflow: auto to div.product in Single Product template in TT2, forcing the div to "occupy" the necessary height, so the footer doesn't collapse.

The issue affects all block theme, but currently we don't have a CSS file specific to block themes, so I'm applying the fix only on TT2, for now. @frontdevde is working on extracting some parts of TT2's stylesheet into a block-specific stylesheet.

Closes #33304.

How to test the changes in this Pull Request:

  1. Create a new product and make sure it has no description, no reviews and no additional information.
  2. With TT2 theme, visit that product in the frontend.
  3. Verify the footer doesn't render on top of the single product template.
Before After
imatge imatge

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@Aljullu Aljullu requested a review from a team June 3, 2022 11:15
@Aljullu Aljullu self-assigned this Jun 3, 2022
@Aljullu Aljullu requested review from barryhughes and removed request for a team June 3, 2022 11:15
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 3, 2022
@botwoo
Copy link
Collaborator

botwoo commented Jun 3, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Add changelog entry 66d9a69
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.


Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

@barryhughes barryhughes merged commit 2b85008 into trunk Jun 3, 2022
@barryhughes barryhughes deleted the fix/33304-single-product-no-reviews-block-themes branch June 3, 2022 15:37
@github-actions github-actions bot added this to the 6.7.0 milestone Jun 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Product with no reviews broken in Twenty Twenty Two Theme

4 participants