Skip to content

Update onboarding email marketing checkbox default to false #33292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adrianduffell merged 6 commits into from
Jun 13, 2022
Merged

Update onboarding email marketing checkbox default to false #33292

adrianduffell merged 6 commits into from
Jun 13, 2022

Conversation

@adrianduffell
Copy link
Contributor

@adrianduffell adrianduffell commented Jun 2, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #33289. This PR makes the email marketing checkbox "Get tips, product updates etc" opt-in by default.

image

How to test the changes in this Pull Request:

  1. On a fresh install, start the onboarding wizard.
  2. See that the marketing checkbox is not ticked by default

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@botwoo
Copy link
Collaborator

botwoo commented Jun 2, 2022 •
edited
Loading

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Merge branch 'trunk' into fix/onboarding-email-optin 34cca4f
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

@adrianduffell
Update e2e test
17fbf8d 
This now asserts that the marketing checkbox is opt-in by default.
@adrianduffell
Add changelog
29b5204
@adrianduffell
Add inline documentation
62f25a8
@github-actions github-actions bot added package: @woocommerce/admin-e2e-tests issues related to @woocommerce/admin-e2e-tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 3, 2022
@adrianduffell adrianduffell marked this pull request as ready for review June 10, 2022 08:09
@adrianduffell adrianduffell requested a review from a team June 10, 2022 08:10
ilyasfoo
ilyasfoo approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, LGTM! :shipit:

@adrianduffell adrianduffell merged commit 1e03b68 into trunk Jun 13, 2022
@adrianduffell adrianduffell deleted the fix/onboarding-email-optin branch June 13, 2022 01:55
@github-actions github-actions bot added this to the 6.7.0 milestone Jun 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022

Hi @adrianduffell, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ilyasfoo ilyasfoo ilyasfoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: @woocommerce/admin-e2e-tests issues related to @woocommerce/admin-e2e-tests plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.7.0

Development

Successfully merging this pull request may close these issues.

"Get tips, product updates etc" mailing list during onboarding should be opt in, not auto-opt-in

4 participants

@adrianduffell @botwoo @ilyasfoo