Skip to content

Add "built by Woo" label to Pinterest #33270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 2 commits into from
May 31, 2022
Merged

Add "built by Woo" label to Pinterest #33270

chihsuan merged 2 commits into from
May 31, 2022

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented May 31, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #33260

This PR adds "built by Woo" label to Pinterest.

How to test the changes in this Pull Request:

  1. Create a fresh site.
  2. Make sure woocommerce_show_marketplace_suggestions is set to no in wp_options table.
  3. Navigate to http://your-site/wp-admin/admin.php?page=wc-admin&task=marketing
  4. Confirm the Pinterest has a "Built by WooCommerce" label

Screen Shot 2022-05-31 at 16 11 14

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 31, 2022
@chihsuan chihsuan self-assigned this May 31, 2022
@chihsuan chihsuan requested a review from a team May 31, 2022 08:12
@chihsuan chihsuan marked this pull request as ready for review May 31, 2022 08:12
@botwoo
Copy link
Collaborator

botwoo commented May 31, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Add changelog 028f0f7
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

siriuz
siriuz approved these changes May 31, 2022
View reviewed changes
Copy link

@siriuz siriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😄

rjchow
rjchow approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😄

@chihsuan chihsuan merged commit cad7621 into trunk May 31, 2022
@chihsuan chihsuan deleted the update/pinterest-built-by-woo branch May 31, 2022 08:46
@github-actions github-actions bot added this to the 6.7.0 milestone May 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2022

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@siriuz siriuz siriuz approved these changes

@rjchow rjchow rjchow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.7.0

Development

Successfully merging this pull request may close these issues.

Marketing task: add "built by Woo" label to Pinterest

5 participants

@chihsuan @botwoo @siriuz @rjchow