Skip to content

Remove the navigation nudge note #33241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshuatf merged 2 commits into from
May 31, 2022
Merged

Remove the navigation nudge note #33241

joshuatf merged 2 commits into from
May 31, 2022

Conversation

@joshuatf
Copy link
Contributor

@joshuatf joshuatf commented May 27, 2022

All Submissions:

Changes proposed in this Pull Request:

Removes the navigation nudge note as it's no longer needed.

Closes #33129 .

How to test the changes in this Pull Request:

  1. Spin up a new site with this branch of WC
  2. Do not enable the new navigation
  3. Visit the homescreen
  4. Make sure the navigation note ("You now have access to the WooCommerce navigation") is not added

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested a review from a team May 27, 2022 17:45
@joshuatf joshuatf self-assigned this May 27, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 27, 2022
@botwoo
Copy link
Collaborator

botwoo commented May 27, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Add changelog entry 56e844f
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

@louwie17 louwie17 self-requested a review May 30, 2022 14:25
louwie17
louwie17 approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
I was thinking, maybe we want to keep the possibly remote note logic, but given the feature still exists, it shouldn't matter if the note still shows for users who updated and didn't dismiss it.

@joshuatf joshuatf merged commit 7590663 into trunk May 31, 2022
@joshuatf joshuatf deleted the remove/33129 branch May 31, 2022 16:09
@github-actions github-actions bot added this to the 6.7.0 milestone May 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2022

Hi @joshuatf, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@mattsherman mattsherman mentioned this pull request Jun 21, 2022
Closed
1 task
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louwie17 louwie17 louwie17 approved these changes

Assignees

@joshuatf joshuatf

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.7.0

Development

Successfully merging this pull request may close these issues.

Remove the wc-admin-navigation-nudge inbox note

4 participants

@joshuatf @botwoo @louwie17