Skip to content

Cleanup and fix translation path changes #33226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rjchow merged 1 commit into from
May 27, 2022
Merged

Cleanup and fix translation path changes #33226

rjchow merged 1 commit into from
May 27, 2022

Conversation

@rjchow
Copy link
Contributor

@rjchow rjchow commented May 27, 2022 •
edited
Loading

Removed temporary codepath added in #32603 since translation paths have been updated

Also there was an error in that PR that causes translations to be broken for wc-admin related translations

All Submissions:

How to test the changes in this Pull Request:

  1. Install Woocommerce and set the site language to a language with good translation coverage such as French or German
  2. Download the translation from the Dashboard > Updates menu
  3. Check that translations are working, both in the onboarding wizard and analytics screens

image

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 27, 2022
@rjchow rjchow force-pushed the dev/cleanup-translation-path-changes branch from fbd1ed8 to f30fa66 Compare May 27, 2022 03:58
@rjchow rjchow marked this pull request as ready for review May 27, 2022 04:00
@rjchow rjchow requested a review from a team May 27, 2022 04:00
@botwoo
Copy link
Collaborator

botwoo commented May 27, 2022 •
edited
Loading

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Cleanup translation path changes 21e0d69
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

chihsuan
chihsuan previously approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjchow Thanks for cleaning up. Tested well and looks good. 🚀

@rjchow rjchow force-pushed the dev/cleanup-translation-path-changes branch 2 times, most recently from 3027877 to 78b00a2 Compare May 27, 2022 05:33
@rjchow rjchow changed the title Cleanup translation path changes Cleanup and fix translation path changes May 27, 2022
chihsuan
chihsuan previously approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rjchow
Cleanup translation path changes
21e0d69 
- removed temporary codepath since translation paths have been updated
@rjchow rjchow force-pushed the dev/cleanup-translation-path-changes branch from 78b00a2 to 21e0d69 Compare May 27, 2022 07:40
@rjchow rjchow merged commit 0f0b2d5 into trunk May 27, 2022
@rjchow rjchow deleted the dev/cleanup-translation-path-changes branch May 27, 2022 08:57
@github-actions github-actions bot added this to the 6.7.0 milestone May 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2022

Hi @rjchow, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@jonathansadowski jonathansadowski modified the milestones: 6.7.0, 6.6.0 May 27, 2022
@jonathansadowski jonathansadowski added the release: cherry-pick Commits from this PR also needs to be added to current release branch. label May 27, 2022
@jonathansadowski jonathansadowski mentioned this pull request May 27, 2022
Merged
@jonathansadowski
Copy link
Contributor

jonathansadowski commented May 27, 2022

This has been cherry-picked into the release/6.6 branch.

@jonathansadowski jonathansadowski removed the release: cherry-pick Commits from this PR also needs to be added to current release branch. label May 27, 2022
@github-actions github-actions bot mentioned this pull request Jun 15, 2022
Closed
This was referenced Jul 4, 2022
Closed
Closed
Closed
This was referenced Jul 7, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rjchow @botwoo @jonathansadowski @chihsuan