Skip to content

Remove changelog files for cherry-picked PRs #32940 and #33171 #33209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonathansadowski merged 1 commit into from
May 26, 2022
Merged

Remove changelog files for cherry-picked PRs #32940 and #33171 #33209

jonathansadowski merged 1 commit into from
May 26, 2022

Conversation

@jonathansadowski
Copy link
Contributor

@jonathansadowski jonathansadowski commented May 26, 2022

All Submissions:

Changes proposed in this Pull Request:

This PR removes the changelog files for the PRs cherry-picked into the release branch in #33191, as their changelog entries will be included in that release

How to test the changes in this Pull Request:

  1. Verify that the removed changelog files are correct.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@jonathansadowski jonathansadowski requested review from a team and roykho and removed request for a team May 26, 2022 14:25
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 26, 2022
@botwoo
Copy link
Collaborator

botwoo commented May 26, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Remove changelog files for cherry-picked PRs #32940 and #33171 bc12371
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

roykho
roykho approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@roykho roykho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathansadowski jonathansadowski merged commit 66633df into trunk May 26, 2022
@jonathansadowski jonathansadowski deleted the delete/33191-changelogs branch May 26, 2022 17:25
@github-actions github-actions bot added this to the 6.7.0 milestone May 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022

Hi @jonathansadowski, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@roykho roykho roykho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jonathansadowski @botwoo @roykho