Skip to content

Conversation

@joshuatf
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Fixes querying of categories in analytics by using term_id instead of term_taxonomy_id.

cc @chihsuan to double check if there was a reason or edge case for using term_taxonomy_id.

Closes #33141 .

How to test the changes in this Pull Request:

  1. Create some categories
  2. Place some orders with products in various categories
  3. Navigate to Analytics->Categories
  4. Make sure the categories and category names load as expected

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf requested review from a team and chihsuan May 23, 2022 16:43
@joshuatf joshuatf self-assigned this May 23, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 23, 2022
@botwoo
Copy link
Collaborator

botwoo commented May 23, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Add changelog entry f819186
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.


Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

Copy link
Contributor

@joelclimbsthings joelclimbsthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuatf Ran through the steps and everything loaded and appeared as expected 👍🏻 🚢

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@joshuatf joshuatf merged commit 97eecfd into trunk May 24, 2022
@joshuatf joshuatf deleted the fix/33141 branch May 24, 2022 13:11
@github-actions github-actions bot added this to the 6.7.0 milestone May 24, 2022
@github-actions
Copy link
Contributor

Hi @joshuatf, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Analytics > Categories API - Dependency on primary key term_taxonomy_id rather than term_id in _term_taxonomy table

5 participants