Skip to content

Fix payment settings banner TOS link #33082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 2 commits into from
May 18, 2022
Merged

Fix payment settings banner TOS link #33082

chihsuan merged 2 commits into from
May 18, 2022

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented May 18, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Change the TOS link to https://wordpress.com/tos/

#33068 (comment)

How to test the changes in this Pull Request:

Just review the changes

or

  1. Follow test instructions on pbIJXs-1P0-p2
  2. Click the TOS link and confirm it goes to the correct page

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 18, 2022
@chihsuan chihsuan self-assigned this May 18, 2022
@chihsuan chihsuan requested a review from a team May 18, 2022 02:25
@chihsuan chihsuan marked this pull request as ready for review May 18, 2022 02:25
@chihsuan chihsuan mentioned this pull request May 18, 2022
Merged
8 tasks
@botwoo
Copy link
Collaborator

botwoo commented May 18, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Add changelog 3ba19b3
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

ilyasfoo
ilyasfoo approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@chihsuan chihsuan merged commit 00d761b into trunk May 18, 2022
@chihsuan chihsuan deleted the fix/update-wcpay-banner-tos-link branch May 18, 2022 03:12
@github-actions github-actions bot added this to the 6.6.0 milestone May 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2022

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Jun 15, 2022
Closed
This was referenced Jul 4, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ilyasfoo ilyasfoo ilyasfoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@chihsuan @botwoo @ilyasfoo