Skip to content

Conversation

@moon0326
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Partially closes #33056 .

This PR updates the description of the WC Pay and redirect the users to the WC Pay connect page upon clicking Get started button when the WC Pay is already installed.

How to test the changes in this Pull Request:

  1. Follow test instructions in pbIJXs-1P0-p2
  2. Confirm the updated description.
  3. Confirm the button redirects you to the WC Pay connect page.

Screenshots

Screen Shot 2022-05-16 at 3 14 05 PM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@moon0326 moon0326 requested a review from a team May 16, 2022 22:22
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 16, 2022
…he WC Pay connect page when the WC Pay is already installed
@moon0326 moon0326 force-pushed the update/33056-update-the-wcpay-description branch from b86f020 to 285047f Compare May 16, 2022 22:37
@botwoo
Copy link
Collaborator

botwoo commented May 16, 2022

📊 Test reports for b86f020 `` have been published and are accessible through the following links:

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

@botwoo
Copy link
Collaborator

botwoo commented May 16, 2022

📊 Test reports for 285047f Update the description and make the button to redirect the users to t… have been published and are accessible through the following links:

Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well. 👍

@moon0326 moon0326 merged commit c6d1987 into trunk May 17, 2022
@moon0326 moon0326 deleted the update/33056-update-the-wcpay-description branch May 17, 2022 03:17
@github-actions github-actions bot added this to the 6.6.0 milestone May 17, 2022
@github-actions
Copy link
Contributor

Hi @moon0326, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Description In Payments Settings when WCPay is Installed but not Set up yet

4 participants