Skip to content

Conversation

@ilyasfoo
Copy link
Contributor

Changes proposed in this Pull Request:

Fixes import product task to only appear when either woocommerce_products_task_layout_card or woocommerce_products_task_layout_stacked experiment is treatment

How to test the changes in this Pull Request:

  1. Go to onboarding wizard's Business Features step
  2. Set "Currently selling elsewhere" to "Yes, on other platform" and save
  3. Install WooCommerce Admin Test Helper
  4. Go to Tools > WCA Test Helper > Features
  5. Enable experimental-import-products-task
  6. Go to Tools > WCA Test Helper > Experiments
  7. Enable treatment for either woocommerce_products_task_layout_stacked or woocommerce_products_task_layout_card for frontend
  8. Go to the products task
  9. Observe the import screen is displayed
  10. Disable treatment for the experiment and refresh product task
  11. Observe the old product task screen is displayed

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 16, 2022
@ilyasfoo ilyasfoo marked this pull request as ready for review May 16, 2022 03:18
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks @ilyasfoo! Could you extract and export this logic so that I can use it for the tracks meta? 😃

@ilyasfoo
Copy link
Contributor Author

@rjchow Sure thing, did that in 40a1eb5. Let me know if that's sufficient

@ilyasfoo ilyasfoo requested a review from rjchow May 16, 2022 04:43
@rjchow rjchow merged commit b524b82 into trunk May 17, 2022
@rjchow rjchow deleted the fix/wrap-import-products-under-experiment branch May 17, 2022 06:57
@github-actions github-actions bot added this to the 6.6.0 milestone May 17, 2022
@github-actions
Copy link
Contributor

Hi @rjchow, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants