Skip to content

Remove WCAdmin deactivation note #33028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilyasfoo merged 2 commits into from
May 13, 2022
Merged

Remove WCAdmin deactivation note #33028

ilyasfoo merged 2 commits into from
May 13, 2022

Conversation

@ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented May 13, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Automatically removes the note Deactivate old WooCommerce Admin version upon install/upgrade WooCommerce

image

How to test the changes in this Pull Request:

  1. In a fresh site, install & activate WooCommerce 6.4.1
  2. Install & activate WooCommerce Admin 3.2.1
  3. Go to Home > WooCommerce
  4. Observe the note "Deactivate old WooCommerce Admin version" exists
  5. Zip plugin with this change (or download the zip here woocommerce.zip)
  6. Upload & activate the plugin
  7. Observe the note is removed after install

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@ilyasfoo ilyasfoo added the release: cherry-pick Commits from this PR also needs to be added to current release branch. label May 13, 2022
@ilyasfoo ilyasfoo added this to the 6.5.0 milestone May 13, 2022
@ilyasfoo ilyasfoo requested a review from a team May 13, 2022 02:46
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 13, 2022
@ilyasfoo
Copy link
Contributor Author

ilyasfoo commented May 13, 2022

Code sniff check is checking unchanged codes, I think it's safe to ignore

image

chihsuan
chihsuan approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyasfoo Thanks for the fix. LGTM and tested well on my JN site. 👍

@ilyasfoo ilyasfoo merged commit 1b0ee6f into trunk May 13, 2022
@ilyasfoo ilyasfoo deleted the fix/remove-deactivate-wcadmin-note branch May 13, 2022 05:59
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2022

Hi @ilyasfoo, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@ilyasfoo ilyasfoo removed the release: cherry-pick Commits from this PR also needs to be added to current release branch. label May 16, 2022
@ilyasfoo ilyasfoo removed this from the 6.5.0 milestone May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilyasfoo @chihsuan