Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented May 12, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #32859.

Add fashion sample products for the product task.

Note: Code sniff check is checking unchanged codes

Screen Shot 2022-05-13 at 12 16 42

How to test the changes in this Pull Request:

Prerequisite

  1. Install WooCommerce Admin Test Helper
  2. Go to Tools > WCA Test Helper > Features
  3. Enable experimental-products-task
  4. Make sure your site has woocommerce_allow_tracking option set to yes

Testing old products import if feature flag is off

  1. Go to Tools > WCA Test Helper > Features

  2. Disable experimental-fashion-sample-products

  3. Go to Tools > WCA Test Helper > Experiments

  4. Enable treatment for either woocommerce_products_task_layout_stacked or woocommerce_products_task_layout_card for backend and frontend (You may need to click "load sample products" once to see the backend experiments)
    Screen Shot 2022-05-13 at 12 14 44

  5. Make sure there are no products in store (if there are in trash, empty them)

  6. Click on "Load sample products"

  7. Go to Products page

  8. Observe that 9 products are imported

Testing fashion products import if feature flag is on

  1. Go to Tools > WCA Test Helper > Features
  2. Enable experimental-fashion-sample-products
  3. Trash all products & empty trash
  4. Go to Products task
  5. Click on "Load sample products"
  6. Observe 9 fashion products are imported

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 12, 2022
@chihsuan chihsuan self-assigned this May 12, 2022
@chihsuan chihsuan force-pushed the add/32859-fashion-sample-products branch from 35df7d5 to e8fc2cb Compare May 13, 2022 04:09
@chihsuan chihsuan force-pushed the add/32859-fashion-sample-products branch from e8fc2cb to 55884d8 Compare May 13, 2022 04:10
@chihsuan chihsuan marked this pull request as ready for review May 13, 2022 04:10
@chihsuan chihsuan requested a review from a team May 13, 2022 04:12
adrianduffell
adrianduffell previously approved these changes May 16, 2022
Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested perfectly and looks good to me! Thanks @chihsuan 🚀

Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving latest changes 👍

@chihsuan chihsuan merged commit 7b3a1db into trunk May 16, 2022
@chihsuan chihsuan deleted the add/32859-fashion-sample-products branch May 16, 2022 09:43
@github-actions github-actions bot added this to the 6.6.0 milestone May 16, 2022
@github-actions
Copy link
Contributor

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add fashion csv sample file

3 participants