Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented May 12, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #32956.

Fixes the notice on the empty product page.

How to test the changes in this Pull Request:

Test no notice on the empty Products page

  1. Make sure debug is enabled
  2. On a fresh site, go to the Products page
  3. Observe NO notice

Test load sample products notice

  1. Install WooCommerce Admin Test Helper
  2. Go to Tools > WCA Test Helper > Features
  3. Enable experimental-products-task
  4. Go to Tools > WCA Test Helper > Experiments
  5. Enable treatment for woocommerce_products_task_layout_stacked
  6. Make sure your site has woocommerce_allow_tracking option set to yes
  7. Navigate to WooCommerce > Home
  8. Go to "Add products" task
  9. Click "Load Sample Products"
  10. Observe that 9 products are loaded, and a notice is displayed

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 12, 2022
@chihsuan chihsuan self-assigned this May 12, 2022
@chihsuan chihsuan requested a review from a team May 12, 2022 01:31
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @chihsuan 👍

Tested well and LGTM 🚀

@chihsuan chihsuan merged commit eb5ef8d into trunk May 13, 2022
@chihsuan chihsuan deleted the fix/32956-notice-on-empty-product-page branch May 13, 2022 02:33
@github-actions github-actions bot added this to the 6.6.0 milestone May 13, 2022
@github-actions
Copy link
Contributor

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notice on empty products page

3 participants