Skip to content

Conversation

@moon0326
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes #32883.

  • Removes react-dates from woocommerce-admin plugin since it's not being used in client/ anymore
  • Updated react-dates to 21.8.0

Breaking Changes

The updated react-dates contains the following breaking changes.

  • Remove propTypes in production
  • Call onDatesChange before onFocusChange in the DRP
  • Omit tabindex prop from calendar navigation buttons when custom buttons are supplied
  • Update react-with-styles and other deps

Our code is not affected.

How to test the changes in this Pull Request:

  1. Run pnpm install from the root
  2. Run pnpm nx build woocommerce-admin
  3. Navigate to Analytics -> Overview
  4. Click Date range: and make sure the date range works as expected.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@moon0326 moon0326 requested a review from a team May 11, 2022 01:16
@github-actions github-actions bot added focus: react admin package: @woocommerce/components issues related to @woocommerce/components plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 11, 2022
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moon0326 Thanks for working on this. LGTM and tested well. 👍

@moon0326 moon0326 merged commit 9720874 into trunk May 11, 2022
@moon0326 moon0326 deleted the update/32883-update-react-dates-dependency branch May 11, 2022 19:49
@github-actions github-actions bot added this to the 6.6.0 milestone May 11, 2022
@github-actions
Copy link
Contributor

Hi @moon0326, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @woocommerce/components issues related to @woocommerce/components plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update react-dates dependency

3 participants