Skip to content

Conversation

@ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented May 10, 2022

Changes proposed in this Pull Request:

Closes #32635.

  • Adds ExPlat API calls for experiment assignment query for both woocommerce_products_task_layout_card and woocommerce_products_task_layout_stacked experiment
  • Adds the experiment condition prior loading experimental product task fills

How to test the changes in this Pull Request:

Prerequisite

  1. Install WooCommerce Admin Test Helper
  2. Go to Tools > WCA Test Helper > Features
  3. Enable experimental-products-task
  4. Make sure your site has woocommerce_allow_tracking option set to yes

Testing control

  1. Navigate to WooCommerce > Home
  2. Go to "Add products" task
  3. Observe the old products task is displayed

Testing card layout

  1. Install WooCommerce Admin Test Helper
  2. Go to Tools > WCA Test Helper > Experiments
  3. Enable treatment for woocommerce_products_task_layout_card
  4. Navigate to WooCommerce > Home
  5. Go to "Add products" task
  6. Observe new products task with card layout

Testing stacked layout

  1. Install WooCommerce Admin Test Helper
  2. Go to Tools > WCA Test Helper > Experiments
  3. Enable treatment for woocommerce_products_task_layout_stacked and disable woocommerce_products_task_layout_card if required
  4. Navigate to WooCommerce > Home
  5. Go to "Add products" task
  6. Observe new products task with stacked layout

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@ilyasfoo ilyasfoo requested a review from a team May 10, 2022 10:42
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 10, 2022
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. @ilyasfoo LGTM and tested well. 💯

@ilyasfoo ilyasfoo merged commit 016a23f into trunk May 11, 2022
@ilyasfoo ilyasfoo deleted the dev/32635-implement-product-task-experiment branch May 11, 2022 05:03
@github-actions github-actions bot added this to the 6.6.0 milestone May 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

Hi @ilyasfoo, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement experiments for Product Task layout

3 participants