Skip to content

Conversation

@chihsuan
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Closes #32884.

  • Remove memoize-one from woo admin since we don't really use it in ./client.
  • Update it to ^6.0.0 for woo components

Breaking Changes

How to test the changes in this Pull Request:

  1. Run pnpm nx build woocommerce-admin
  2. Go to Analytics > Overview
  3. Confirm that all charts should be rendered without errors.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin package: @woocommerce/components issues related to @woocommerce/components plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 10, 2022
@chihsuan chihsuan force-pushed the update/memoize-one branch from e7e51e6 to 4f1e7af Compare May 10, 2022 06:29
@chihsuan chihsuan marked this pull request as ready for review May 10, 2022 06:40
@chihsuan chihsuan self-assigned this May 10, 2022
@chihsuan chihsuan requested a review from a team May 10, 2022 06:40
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on it 👍

LGTM and tested well 🚀

@chihsuan chihsuan merged commit 79814cc into trunk May 11, 2022
@chihsuan chihsuan deleted the update/memoize-one branch May 11, 2022 01:55
@github-actions github-actions bot added this to the 6.6.0 milestone May 11, 2022
@github-actions
Copy link
Contributor

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @woocommerce/components issues related to @woocommerce/components plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update memoize-one dependency

3 participants