Skip to content

Conversation

@james-allan
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This is a temporary change to be enable testing the full flow whilst we work on setting up the experiment and directing users through their designated flows.

Part of #32694

How to test the changes in this Pull Request:

  1. Checkout this branch and run pnpm nx build-watch woocommerce-admin to build assets
  2. Make sure you meet all the eligibility criteria by uninstalling WooCommerce Payments and WooCommerce Subscriptions
  3. Navigate to WooCommerce > Subscriptions
  4. Click the "Get started" button.
  5. Once the plugin activation is complete, you should be redirected to the create product screen with subscription product type preselected.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

…Payments

This is a temporary measure to be enable testing the full flow whilst we
work on setting up the experiment.
Copy link
Contributor

@aprea aprea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observed some weird behaviour when testing this.

After clicking the "Get started" button I observed the requests to install/activate WooCommerce Payments in the dev console. These requests took a few seconds each.

But then the request to navigate to the post-new.php page took over a minute.

Screen Shot 2022-05-10 at 4 14 30 pm

The bulk of this time was spent in the Waiting/TTFB category. There might be a non-critical backend HTTP request that is executed during this request that is stalling and timing out. I'm able to reproduce this 100% of the time.

I don't suppose you ran into this @james-allan?

In any case, the code looks correct and the page eventually loads so I'm okay with approving this and I can potentially debug this later. It might just be a quirk with my local environment 🤷‍♀️

@james-allan
Copy link
Contributor Author

I don't suppose you ran into this?

Nah mine isn't taking that long.

The plugin install request takes ~14 seconds, activation is ~2 seconds and then the redirect is taking ~6.5 seconds on my local.

Screen Shot 2022-05-10 at 4 29 17 pm

@aprea
Copy link
Contributor

aprea commented May 10, 2022

No worries, thanks! Let's see what these numbers look like in a product environment/Jurassic Ninja, hopefully, they're way lower 🤞.

@james-allan james-allan merged commit e071bf1 into add/experiment-subscriptions-admin-menu-1 May 10, 2022
@james-allan james-allan deleted the add/experiment-subscriptions-redirect-after-install branch May 10, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants