Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented May 9, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #32451.

This PR changes the wcpay task display logic:

  • Display the task regardless of how it's installed
  • Only display the task if the task list has not been completed.

How to test the changes in this Pull Request:

Display the wcpay task when WooCommerce Payments is installed during the OBW

  1. Use a fresh site
  2. Choose a supported country like US in the Store Details step
  3. Install WooCommerce Payments in the Business Details / Free Features step.
  4. Go to Woocommerce > Home
  5. Observe that Get paid with WooCommerce Payments task is displayed

Display the wcpay task when WooCommerce Payments is installed via Plugins > Add New

  1. Use a fresh site
  2. Choose a supported country like US in the Store Details step
  3. Uncheck WooCommerce Payments in the Business Details / Free Features step.
  4. Install WooCommerce Payments via Plugins > Add New
  5. Go to Woocommerce > Home
  6. Observe that Get paid with WooCommerce Payments task is displayed

Do not display the wcpay task when task list has been completed

  1. Use a fresh site
  2. Choose a supported country like US in the Store Details step
  3. Uncheck WooCommerce Payments in the Business Details / Free Features step.
  4. Go to Woocommerce > Home
  5. Complete all tasks
  6. Install WooCommerce Payments via Plugins > Add New
  7. Go to Woocommerce > Home
  8. Observe that Get paid with WooCommerce Payments task is NOT displayed

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 9, 2022
@chihsuan chihsuan self-assigned this May 9, 2022
@chihsuan chihsuan requested a review from a team May 9, 2022 08:50
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍 🚀

@chihsuan chihsuan merged commit 879ccdb into trunk May 10, 2022
@chihsuan chihsuan deleted the update/32451-wcpay-task-display-logic branch May 10, 2022 02:07
@github-actions github-actions bot added this to the 6.6.0 milestone May 10, 2022
@github-actions
Copy link
Contributor

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WCPayments task: change the display logic

3 participants