-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Add a dismiss ("No thanks") button to the WCPay Subscriptions welcome page #32913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dismiss ("No thanks") button to the WCPay Subscriptions welcome page #32913
Conversation
| > | ||
| { __( 'Get started', 'woocommerce' ) } | ||
| </Button> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks larger than it actually is. So the two buttons were in the same wrapper container, I moved this div out of here and put in the MainContent component instead, see change directly below this one. Let me know if there's a better way to do this.
e3bd401 to
738b376
Compare
… options instead of using apiFetch
aprea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM and is working as expected 👍
|
Hi @james-allan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
All Submissions:
Changes proposed in this Pull Request:
This PR adds a button to the WooCommerce > Subscriptions screen that users can use to hide/dismiss the menu item.
Closes #32909
How to test the changes in this Pull Request:
pnpm nx build-watch woocommerce-admin* this UX hasn't been agreed to so feel free to give me feedback on that.
Other information:
pnpm nx affected --target=changelog?FOR PR REVIEWER ONLY: