Skip to content

Conversation

@aprea
Copy link
Contributor

@aprea aprea commented May 5, 2022

All Submissions:

Changes proposed in this Pull Request:

This PR implements a new design for the WooCommerce > Subscriptions (experiment) page.

Before After
localhost_8888_wp-admin_admin php_page=wc-admin path=%2Fsubscriptions (1) localhost_8888_wp-admin_admin php_page=wc-admin path=%2Fsubscriptions

Please see #32691 for more information.

How to test the changes in this Pull Request:

  1. Checkout this branch and run pnpm nx build-watch woocommerce-admin to build assets
  2. With WooCommerce Payments and WooCommerce Subscriptions inactive, navigate to WooCommerce > Subscriptions
  3. Observe the new design. There shouldn't be any spelling mistakes or layout issues.
  4. Clicking the "Get started" button should function as per before, i.e. it downloads and installs the WooCommerce Payments plugin.
  5. The existing error handling should continue to work. See Display an error message when WC Payments fails to install via the Subscriptions menu item #32852 for testing instructions.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@aprea aprea requested review from Jinksi and james-allan May 5, 2022 05:14
@aprea aprea added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 5, 2022
@github-actions github-actions bot removed the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 5, 2022
Copy link
Contributor

@Jinksi Jinksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @aprea 👏 I've suggested a couple of changes/comments.

  • Layout matches the design
  • Text is free of spelling errors (suggested a wording change to match design)
  • Display error works as expected
  • Installation of WCPay works as expected

Copy link
Contributor

@james-allan james-allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left a tiny little nitpick comment but happy to approve without it.

@aprea aprea merged commit 0a5c10f into add/experiment-subscriptions-admin-menu-1 May 9, 2022
@aprea aprea deleted the add/experiment-subscriptions-admin-new-design branch May 9, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants