-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Display an error message when WC Payments fails to install via the Subscriptions menu item #32852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display an error message when WC Payments fails to install via the Subscriptions menu item #32852
Conversation
| * Navigate to either newSubscriptionProductUrl or onboardingUrl | ||
| * depending on the which treatment the user is assigned to. | ||
| */ | ||
| // eslint-disable-next-line no-console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this was necessary to get over WC's linting on commit. It can be removed once we remove the following console log.
|
Just noting that I changed (b15cfd3) the error message to follow a better sentence structure IMO. We'll want to get broader feedback on this messaging anyway but just wanted to highlight it. |
aprea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I tested both the happy and sad paths, both are working as expected.

All Submissions:
Changes proposed in this Pull Request:
This PR adds error handling to the WooCommerce > Subscriptions (experiment) page if the "Get Started" buttons fails to install WooCommerce Payments.
part of #32694
How to test the changes in this Pull Request:
pnpm nx build-watch woocommerce-adminto build assets'DISALLOW_FILE_MODS'const to your site (see example below).Note: without the
DISALLOW_FILE_MODSset to true, the "Get started" button will install (if necessary) and activate WooCommerce Payments but the page will appear to hang and the button will be stuck on processing. This is intended for now and will be handled by the rest of #32694 once the experiment allocation is settled.Other information:
pnpm nx affected --target=changelog?FOR PR REVIEWER ONLY: