-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Fix: Twenty Twenty-Two integration #32840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Twenty Twenty-Two integration #32840
Conversation
Aljullu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this @dinhtungdu!
I will leave somebody from Proton do the final review.
|
seems like tests are failing but seems like an intermittent error, i am restarting them to see if that fixes it. |
|
@vedanshujain @Aljullu I've just realized that we lose the wrapper width of the checkout page. In 043aaf4, I add the wrapper width back and remove the unnecessary style for the account page. Please give this another review! |
Aljullu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vedanshujain @Aljullu I've just realized that we lose the wrapper width of the checkout page.
Good catch! New changes look good to me.
|
@vedanshujain can you merge this PR? It looks like neither @dinhtungdu neither I can merge it. |
|
Hi @vedanshujain, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|

All Submissions:
Changes proposed in this Pull Request:
There are some issues with the current Twenty Twenty-Two integration (which is detailed in woocommerce/woocommerce-blocks#5863):
This PR fixes those issues by removing the hard-coded width and adding the wrapper back to fix the alignment issue.
The initial width of the wrapper will be set to 650px. This can be fixed in
woocommerce/woocommerce-gutenberg-products-blockby setting the default alignment of the Classic Template block towide.Update: The default layout was changed to
widein woocommerce/woocommerce-blocks#6356.Fixes woocommerce/woocommerce-blocks#5863.
How to test the changes in this Pull Request:
Other information:
pnpm nx affected --target=changelog?FOR PR REVIEWER ONLY: