-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Add load sample products for experimental product task #32815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6c05497 to
02194b7
Compare
396b863 to
1d0689b
Compare
d346564 to
6ef82a7
Compare
1663360 to
345a2ed
Compare
6ef82a7 to
692fd92
Compare
692fd92 to
1d364fa
Compare
9374f7c to
5e6511b
Compare
| */ | ||
| import { __ } from '@wordpress/i18n'; | ||
| import { Modal } from '@wordpress/components'; | ||
| import { Spinner } from '@wordpress/components/build/ui'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { Spinner } from '@wordpress/components/ui'; <- This doesn't work because ui doesn't export in @wordpress/components's index.js
cf8839b to
4f239fc
Compare
|
Converted this to the draft. I'll need to make some changes once #32835 is merged. |
4f239fc to
a76e09e
Compare
a76e09e to
a4bd70c
Compare
| new WooCommerceDependencyExtractionWebpackPlugin(), | ||
| new WooCommerceDependencyExtractionWebpackPlugin( { | ||
| requestToExternal( request ) { | ||
| if ( request === '@wordpress/components/build/ui' ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have three different Spinner components:
And we need to use the one from @wordpress/components/ui/spinner, but it's not included in external wp.components.
moon0326
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked perfectly! 👍
LGTM and tested well 🚀
|
Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
All Submissions:
Changes proposed in this Pull Request:
Closes #32412.
Add feature to load sample products.
How to test the changes in this Pull Request:
plugins/woocommerce/client/admin/config/development.jsonand changeexperimental-products-task&experimental-import-products-tasktotruepnpm nx start woocommerce-adminAdd products view
WooCommerce > Home& click the"Add my products"task"Load Sample Products""Continue setting up your store"-> should redirect to WooCommerce homeSHOW_STACK_LAYOUTto false here.WooCommerce > Home& click the"Add my products"task"View more product types""CAN’T DECIDE?"card"Continue setting up your store"-> should redirect to WooCommerce homeImport products view
Yes, on another platformin the Business Details step.WoocCommerce -> Homeand clickAdd my products"Or add your products from scratch""Load Sample Products""Continue setting up your store"-> should redirect to WooCommerce homeOther information:
pnpm nx affected --target=changelog?FOR PR REVIEWER ONLY: