-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Add experimental add product for task list #32801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b337ba1 to
4936526
Compare
4936526 to
3d80640
Compare
9b233fa to
06b031f
Compare
396b863 to
1d0689b
Compare
moon0326
previously approved these changes
Apr 28, 2022
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1663360 to
345a2ed
Compare
moon0326
approved these changes
Apr 29, 2022
Contributor
moon0326
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Contributor
|
Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
4 tasks
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes #32634.
Implement experimental product page with two layouts:
Stack layout:
Card layout:
How to test the changes in this Pull Request:
plugins/woocommerce/client/admin/config/development.jsonand changeexperimental-products-taskto truepnpm nx dev woocommerce-adminThe visible product types depend on what the user declared during the signup (step 3 - Product types - What type of products will be listed?). The other ones are collapsed.
Card Layout
SHOW_STACK_LAYOUTto false in this line.pnpm nx dev woocommerce-adminOther information:
pnpm nx affected --target=changelog?FOR PR REVIEWER ONLY: