Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Apr 26, 2022

All Submissions:

Changes proposed in this Pull Request:

This PR adds a stack component for #32634 and #32143. I'll implement functionalities in the following PRs.

Screen Shot 2022-04-26 at 18 47 12

How to test the changes in this Pull Request:

  1. Open the plugins/woocommerce/client/admin/config/development.json and change experimental-products-task to true
  2. Run pnpm nx dev woocommerce-admin
  3. Go to WooCommerce > Home & click the "Add my products" task
  4. Observe that the stack component is shown, including a 1.5 px Gutenberg-blue border when components are hovered.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

Base automatically changed from add/32772-exp-product-tasks-feature-flag to trunk April 26, 2022 10:54
@chihsuan chihsuan self-assigned this Apr 26, 2022
@chihsuan chihsuan changed the title Add product stack component Add product stack layout Apr 26, 2022
@chihsuan chihsuan changed the title Add product stack layout Add product stack component Apr 27, 2022
@chihsuan chihsuan force-pushed the add/product-stack branch from 722573d to 588cdd5 Compare April 27, 2022 01:58
@chihsuan chihsuan changed the title Add product stack component Add experimental product stack component Apr 27, 2022
@chihsuan chihsuan force-pushed the add/product-stack branch from 588cdd5 to 8e8f02d Compare April 27, 2022 02:01
@chihsuan chihsuan marked this pull request as ready for review April 27, 2022 02:10
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 27, 2022
@chihsuan chihsuan requested a review from a team April 27, 2022 02:11
@chihsuan chihsuan force-pushed the add/product-stack branch 4 times, most recently from 4376890 to 1ea0146 Compare April 27, 2022 04:07
@chihsuan chihsuan force-pushed the add/product-stack branch 2 times, most recently from a3e0b3b to 026a902 Compare April 27, 2022 08:12
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on it @chihsuan 👍

LGTM and tested well! 🚀

@chihsuan chihsuan merged commit 0389bc7 into trunk Apr 28, 2022
@chihsuan chihsuan deleted the add/product-stack branch April 28, 2022 01:47
@github-actions github-actions bot added this to the 6.6.0 milestone Apr 28, 2022
@github-actions
Copy link
Contributor

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants