@barryhughes good catch, what do you think of b0f5746?

Perfect, thank you @unfulvio-godaddy.

Sorry, all. We have one last set of tasks to do, to resolve the remaining CI fails:

	public function db_update_version_provider() {
		return array(
			// [DB Update version string, # of expected pending jobs]
			array( '3.9.0', 35 ),
			array( '4.0.0', 28 ),
			array( '4.4.0', 24 ),
			array( '4.5.0', 22 ),
			array( '5.0.0', 18 ),
			array( '5.6.0', 16 ),
			array( '6.0.0', 9 ),
			array( '6.3.0', 6 ),
			array( '6.4.0', 3 ),
			array( '6.5.0', 2 ),
			array( '6.6.0', 1 ),
			array( '6.7.0', 0 ),
		);
	}

Significance: minor
Type: add


Add a new Product Reviews admin screen, and remove reviews from the existing Comments admin screen.

I would have handled this myself to save you the trouble, but unfortunately in this case I cannot update the PR directly.

@barryhughes no worries! sorry about this, and thanks for the instructions: please check the latest commits - does everything look alright to you? happy to get this to the finish line! :)

Thanks, @unfulvio-godaddy!

I triggered a re-run of our checks so let's see what comes back—though I think we need more changes to the test in WC_Admin_Tests_Install (if you look back at the snippet in my last comment, the counts were updated for previous versions, too ... which I realize isn't ideal and perhaps not intuitive).

sorry -- so, 0839232 ?

Thanks, that looks right to me 👍

Triggered a re-run of CI.

1) Automattic\WooCommerce\Tests\Internal\Admin\ProductReviews\ReviewsListTableTest::test_current_action with data set "neither deletes are set" (false, false, false)
Failed asserting that 'woocommerce_update_api_key' is identical to false.

I re-ran in case the issue was sporadic, but the above test (introduced via this change) is failing—seemingly only under PHP 7.2 and WP 5.8. Not immediately sure why that would be 🤔

@barryhughes based on that error message, I think what happened is that the current_action from the parent page which is fetching the $_REQUEST variable was being overwritten by other code internally while tests were being run. Unfortunately the tests are not always in isolation in the test suite because they're more integration tests than unit tests. I tried to edit the test to ignore that and just focus on the logic introduced by ReviewsListTable::current_action() in 74c9039 - i hope this fixes it

Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

• Add the release: add testing instructions label