Skip to content

Refactor and improve tests payments task #32662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilyasfoo merged 5 commits into from
Apr 20, 2022
Merged

Refactor and improve tests payments task #32662

ilyasfoo merged 5 commits into from
Apr 20, 2022

Conversation

@ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented Apr 18, 2022 •
edited by moon0326
Loading

Changes proposed in this Pull Request:

  • Lints DefaultPaymentGateway.php
  • Reenable payment task e2e tests
  • Moves out convoluted logic from PaymentGatewaySuggestion to provide better test exposure
  • Adds tests for the extracted functions

How to test the changes in this Pull Request:

  1. Run a quick test on "Set up payments" task and make sure things work as usual
  2. From plugins/woocommerce-admin, run pnpm run test:client plugins/woocommerce-admin/client/tasks/fills/PaymentGatewaySuggestions/test/utils.js and make sure test passes

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file by running pnpm nx affected --target=changelog?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin package: @woocommerce/admin-e2e-tests issues related to @woocommerce/admin-e2e-tests labels Apr 18, 2022
@ilyasfoo ilyasfoo force-pushed the update/refactor-and-improve-tests-payments-task branch from e2264f6 to f9f8510 Compare April 18, 2022 09:20
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 18, 2022
@ilyasfoo ilyasfoo marked this pull request as ready for review April 19, 2022 11:59
@ilyasfoo ilyasfoo requested a review from a team April 19, 2022 11:59
moon0326
moon0326 approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this @ilyasfoo

Everything worked as expected and tests passed without an error 🚀

@ilyasfoo ilyasfoo merged commit 62de7ba into trunk Apr 20, 2022
@ilyasfoo ilyasfoo deleted the update/refactor-and-improve-tests-payments-task branch April 20, 2022 02:38
@github-actions github-actions bot added this to the 6.6.0 milestone Apr 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022

Hi @ilyasfoo, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Jun 15, 2022
Closed
This was referenced Jul 4, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@moon0326 moon0326 moon0326 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: @woocommerce/admin-e2e-tests issues related to @woocommerce/admin-e2e-tests plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

6.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ilyasfoo @moon0326