Good job @joelclimbsthings! The code looks good and it's working as expected but I'm not sure about the current behavior.

There are a few tasks that don't refresh the page after finishing them and the badge doesn't update, creating some confusion.

Is it possible to update the remaining tasks badge on the fly?
Another option that I can imagine is to force a page refresh after finishing each step. I would add a check to confirm that the experiment is turned on to narrow down that behavior just to the experiment.

Just in case, referring to step 3 in the testing instructions; if I skip the OBW (without finishing any tasks) I see the badge displaying the remaining tasks. Is that expected?

Thanks for the review @octaedro !

There are a few tasks that don't refresh the page after finishing them and the badge doesn't update, creating some confusion.

Yeah, I actually mentioned this in my "Notes" above. We can definitely do this, although it would just be altering the markup via JS, so feels a bit hacky. That said I still may be in favor of it.

Also, we'd want to ensure that's it's only executed when a task doesn't result in a page refresh, and I'm not sure offhand if there's a good preexisting place to do that, or if we'd have to do something tricky.

Just in case, referring to step 3 in the testing instructions; if I skip the OBW (without finishing any tasks) I see the badge displaying the remaining tasks. Is that expected?

Actually not sure on this one. The original issue doesn't mention that as an exception, but we'd have to ask @jarekmorawski to clarify.

Thank you @joelclimbsthings for your answer.

Yeah, I actually mentioned this in my "Notes" above. We can definitely do this, although it would just be altering the markup via JS, so feels a bit hacky. That said I still may be in favor of it.

Since this is something with high visibility, I would be cautious about possible inconsistencies because they could be seen as bugs by the user that doesn't refresh the page. Is there a chance for us to improve that?

// CCing @pmcpinto and @jarekmorawski , to have more insights about the expected behavior here.

Thanks @octaedro , I've gone ahead and tentatively added the dynamic update in 48bccc1. I've also updated the feature flag logic to work with the setup task list experiments, and rebased the branch on the current state of trunk.

There are a few tasks that don't refresh the page after finishing them and the badge doesn't update, creating some confusion.

Considering this, I wonder I we should show just "1" in the badge instead of the number of incomplete tasks. @jarekmorawski @verofasulo what do you think?

Considering this, I wonder I we should show just "1" in the badge instead of the number of incomplete tasks. @jarekmorawski @verofasulo what do you think?

"1" can be misleading since it's not entirely clear what it'd mean. How about an asterisk or a simple red dot? Anything to indicate there are things in there that require people's attention. 🤔

Hey @octaedro , I've resolved the issues you brought up, and also took the liberty of tweaking the condition controlling the reminder bar since it was out of date.

Thanks!

The only hiccup I had was that hiding the task list didn't result in the badge disappearing until after a refresh.

Nice catch. Since the remedy would be fairly inelegant and hacky, and it's a fairly rare event, I'm opting for leaving it as is for now. We can revisit if needed.

Hi @joelclimbsthings, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

• Add the release: add testing instructions label

Just noting this PR was merged with a failing k6 test due to the badge addition causing the k6 test assertion (which used the home menu item) to fail.

PR to update the assertion here #33044