Skip to content

Conversation

@louwie17
Copy link
Contributor

Fixes #32161

This is @joelclimbsthings PR moved from woocommerce-admin repo.
This is the implementation of the reminder bar described in this issue. It will display on top of the header on a subset of pages, only when the task list is visible, and direct the user back to the task list.

Notes:

  • This is currently manually assigned to use the task list with ID setup_experiment_1. We may need to add logic to this as we put together the experiment.
  • I've currently got this functionality behind the tasklist-setup-experiment-1 feature flag, which will also be consolidated as we implement the experiment in another issue.
  • This is added inside the preexisting <Header /> component to leverage the scroll and top margin logic that already existed.

Also note that I won't be around to merge or respond to feedback, so I'll need someone else to do so.

Screenshots

image

Detailed test instructions:

  • Checkout branch on a fresh site (if your store is > 4 weeks old it will automatically hide the reminder bar)
  • Enable the tasklist-setup-experiment-1 feature flag.
  • Complete the OBW
  • Complete a single step of the primary task list.
  • You should not see the reminder bar on the Homescreen or any other page related to the tasks. You should see it everywhere else.
  • Go to a non-task related page, such as Orders, and you should see the bar appear above the header. Ensure the copy starts with "You're doing great!"
  • Click the link, which should redirect you to the Homescreen.
  • Complete all but one task remaining.
  • Go back to the Orders (or otherwise) page to view the reminder bar. It should appear similar but have different copy, starting with "Almost there."
  • Click the link again to ensure that it returns you to the homescreen.
  • Hide the list by clicking the ..' menu, and then return to the Orders page. The bar should now not be displayed.
  • Re-enable task list by going to Orders->Help->Setup Wizard->Task List -> Enable.
  • The reminder bar should now reappear when viewing the Orders page.
  • Complete the task list.
  • The reminder bar will no longer display on the Orders page.

@louwie17 louwie17 requested a review from a team March 22, 2022 15:30
@github-actions github-actions bot added focus: react admin package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Mar 22, 2022
@louwie17
Copy link
Contributor Author

@joelclimbsthings this PR looks great and tested well, I did make one small change to the naming of completedTasks given that was the length and I changed it back to being an array.
Also I think it would be nice for the bar to slide down quickly (some sort of animation), given it's not there immediately and there is a small jump when it shows up.
I could also add this, but I am fine if this is done in a separate PR.

For the person officially reviewing this, these were the two commits I added: 371ce71, 44d9824

Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @joelclimbsthings and thank you @louwie17 for reviewing this PR. I tested this and worked well on my end, +1 to Lourens' suggestion about the animation.

@louwie17 louwie17 merged commit eb081aa into trunk Mar 23, 2022
@louwie17 louwie17 deleted the add/32161_reminder_bar branch March 23, 2022 20:12
@github-actions github-actions bot added this to the 6.5.0 milestone Mar 23, 2022
@github-actions
Copy link
Contributor

Hi @louwie17, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add changelog label
  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup experiment: setup reminder bar

4 participants