Skip to content

Add inline file delivery to WC_Download_Handler #31145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
barryhughes merged 11 commits into from
Aug 25, 2022
Merged

Add inline file delivery to WC_Download_Handler #31145

barryhughes merged 11 commits into from
Aug 25, 2022

Conversation

@vedanshujain
Copy link
Contributor

@vedanshujain vedanshujain commented Nov 11, 2021

Rebased PR #28412 from trunk

Original description

Create a new setting option for inline file delivery for downloadable
products. In the Download Handler create a new method for the new
setting as well as a method for returning the proper headers to deliver
files inline.

Resolves: #28410

All Submissions:
Have you followed the WooCommerce Contributing guideline?
Does your code follow the WordPress' coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Changes proposed in this Pull Request:
Creates a new setting for allowing downloadable product files to be delivered inline so they would open directly in the browser. This would be useful for stores selling HTML or PDF files so customers can access them directly without the need to download.

Only other change was aligning => signs in an array to match WordPress indentation coding standards.

Closes #28410 .

How to test the changes in this Pull Request:
Create a downloadable/virtual product.
From Woocommerce Settings > Products > Downloadable Products select Inline File Delivery
Create a test purchase of the downloadable product
Test download delivery
Other information:
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you successfully run tests with your changes locally?
Changelog entry
Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Changelog

Enhancement - Add setting for inline file delivery.

vedanshujain added a commit that referenced this pull request Nov 11, 2021
@vedanshujain
Add new setting for test, see #31145.
2b92d40
@vedanshujain vedanshujain added the needs: documentation The issue/PR requires documentation to be added. label Nov 11, 2021
@vedanshujain vedanshujain mentioned this pull request Nov 11, 2021
Closed
5 tasks
@ObliviousHarmony ObliviousHarmony added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 21, 2022
@CaldwellYSR
Copy link
Contributor

CaldwellYSR commented Jun 15, 2022 •
edited
Loading

Are we getting any closer with this? I'm still having to patch woocommerce every update and I would love to get rid of that debt.

Is there anything I can do to help it move forward?

@CaldwellYSR
Copy link
Contributor

CaldwellYSR commented Aug 23, 2022

Are we getting any closer with this? I'm still having to patch woocommerce every update and I would love to get rid of that debt.
Is there anything I can do to help it move forward?
@vedanshujain

CaldwellYSR and others added 9 commits August 25, 2022 20:39
@CaldwellYSR @vedanshujain
Add inline file delivery to WC_Download_Handler
c6f7c57 
Create a new setting option for inline file delivery for downloadable
products. In the Download Handler create a new method for the new
setting as well as a method for returning the proper headers to deliver
files inline.

Resolves: #28410
@CaldwellYSR @vedanshujain
Update Content Type of inline delivered files
f80fa6d
@CaldwellYSR @vedanshujain
Update Downloaded file name
9a04777
@CaldwellYSR @vedanshujain
Change content-disposition to be a checkbox
6f64cb5 
Since inline-delivery works with multiple download methods
@CaldwellYSR @vedanshujain
Document function
3804544
@vedanshujain
Add new setting for test, see #31145.
2bb21a6
@vedanshujain
Better setting wording and remove typo comment.
b7f9757
@vedanshujain
Address pr feedback.
8b12259
@vedanshujain
Add changelog.
f486da6
@vedanshujain vedanshujain force-pushed the allow-inline-downloads branch from 20da5c1 to f486da6 Compare August 25, 2022 15:26
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022 •
edited
Loading

Test Results Summary

Commit SHA: 8e927df

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests000000NaNm NaNs
E2E Tests186001018713m 51s
 To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@barryhughes barryhughes merged commit e8eb000 into trunk Aug 25, 2022
@barryhughes barryhughes deleted the allow-inline-downloads branch August 25, 2022 18:03
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot added this to the 7.0.0 milestone Aug 25, 2022
@barryhughes barryhughes added the release: highlight Issues that have a high user impact and need to be discussed/paid attention to. label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barryhughes barryhughes barryhughes approved these changes

Assignees

No one assigned

Labels

needs: documentation The issue/PR requires documentation to be added. plugin: woocommerce Issues related to the WooCommerce Core plugin. release: highlight Issues that have a high user impact and need to be discussed/paid attention to.

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Downloadable Products -- Inline file delivery

5 participants

@vedanshujain @CaldwellYSR @barryhughes @ObliviousHarmony