-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Revamp Featured page in WooCommerce Marketplace #30900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f8a1e25 to
618eca7
Compare
Returning country in request to featured 2.0 endpoint.
|
(The 404 on the script was because GitHub changed the PasteBin link.) |
… to improve rendering of promotional banner on featured page.
|
Hi @tgglv, there are merge conflicts, can you please address them? |
barryhughes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last note from me (re ::get_featured()), plus we need to resolve conflicts per note from @Konamiman.
Those things done, it should be good to merge 👍
Hey @Konamiman, fortunately, conflicts are gone. |
barryhughes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@andfinally I didn't want to merge without your approval on the PR, but we're all set from my perspective. |
|
Hi @Konamiman, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
|
I have updated the testing instructions since they were pointing to the deprecated |
All Submissions:
Changes proposed in this Pull Request:
Related to 11239-gh-Automattic/woocommerce.com.
We want to revamp the Marketplace page according to Figma designs. Together with the new design, the approach of treating data from WooCommerce.com API was changed as well. Instead of the current approach of sections/containers for products and banners, the new approach uses groups of products displayed one after another.
Changes:
How to test the changes in this Pull Request:
Preparation
There're 2 options:
For the 2nd option save the script in
index.phpfile and launch PHP-Builtin server with the command like:Disable using transient by changing the first line of the
render_featuredmethod inincludes/admin/class-wc-admin-addons.phpto:$featured = false;Change the API URL used in
$raw_featured = wp_safe_remote_get(...in the same method fromhttps://woocommerce.test/wp-json/wccom-extensions/2.0/featuredtohttp://host.docker.internal:9000(you may need to change the function used towp_remote_getas well)Testing
Open your testing WP site with WooCommerce on this branch
Open WP Admin > WooCommerce > Marketplace page, make sure that you are viewing the "Featured" section
You should see something similar to the image below:

Try extensions search (e.g. via typing "memberships"), the page should look as expected
Other information:
Changelog entry
FOR PR REVIEWER ONLY: