Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

• Add the status: needs changelog label
• Add the status: needs testing instructions label

Hi guys! I am thos one posting the original issue.

We now found another scenario that triggers this problem with the transients displaying prices without VAT.
We tried to apply the fix given here by @vedanshujain , but unfortunately it does not work as desired in our scenario.

Our client has a store that uses user roles to display discounted prices for wholesale/retailers. Once a retailer logs in, immediately the cross-out prices and the discounted price shows without VAT, even all the settings are set to include VAT.

What makes it worse, once the prices are saved in the transients, any clients regardless of the user role are now able to see and checkout with the VAT0% pricing that creates a huge loss of profits.

Clearing the transients fixes the issue temporarily once incorrect prices are discovered, but this requires a huge amount of manual work and constantly monitoring the store for the bug to happen.

Due to client confidentiality I am not able to share the link here publicly, but if you need, we have a staging version of the site available for troubleshooting/ testing. Just let me know how to share those with you in private.

Hi @masahrpro,

Since the user role isn't used by core WooCommerce in pricing, I think the solution should be to use the woocommerce_get_variation_prices_hash filter to add the user's role to the price hash.

If you are using an extension from our marketplace for role based pricing, let us know so we can surface the issue to the developers.

Thanks for the tip @jeffstieler ! We will try that.
We are using the "https://www.role-editor.com/" and I have also contacted them regarding this.
Although, even users not affected by the user role editor- plugin are affected, as the incorrect prices are saved in the transients and require to be cleared to fix the display of the prices.