Skip to content

update chile regions #30875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
barryhughes merged 6 commits into from
Nov 9, 2021
Merged

update chile regions #30875

barryhughes merged 6 commits into from
Nov 9, 2021

Conversation

@masteradhoc
Copy link
Contributor

@masteradhoc masteradhoc commented Oct 4, 2021 •
edited by barryhughes
Loading

All Submissions:

Changes proposed in this Pull Request:

add chile regions based on https://en.wikipedia.org/wiki/ISO_3166-2:CL

Closes #30375

How to test the changes in this Pull Request:

  1. setup a new store
  2. check regions added for chile f.e. on checkout

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Tweak - Improve internationalization and add regions for Chile.

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@masteradhoc masteradhoc mentioned this pull request Oct 4, 2021
Closed
@masteradhoc masteradhoc marked this pull request as ready for review October 7, 2021 15:34
@vedanshujain vedanshujain requested review from a team and barryhughes and removed request for a team November 3, 2021 08:55
barryhughes
barryhughes requested changes Nov 3, 2021
View reviewed changes
Copy link
Member

@barryhughes barryhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Left some notes and requests for minor changes. We should also rebase this to resolve a couple of conflicts.

barryhughes
barryhughes requested changes Nov 5, 2021
View reviewed changes
Copy link
Member

@barryhughes barryhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those updates, @masteradhoc—though it looks like includes/class-wc-countries.php was accidentally deleted in its entirety, rather than just reverting the specific changes to that file.

barryhughes
barryhughes reviewed Nov 8, 2021
View reviewed changes
barryhughes
barryhughes requested changes Nov 8, 2021
View reviewed changes
Copy link
Member

@barryhughes barryhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

One final tweak (possible typo—though let me know if I'm mistaken), plus it looks like a further rebase against latest trunk is needed to resolve a conflict.

@barryhughes
Copy link
Member

barryhughes commented Nov 9, 2021

Rebased to resolve conflicts/match new mono-repo structure. Checking tests pass and can merge.

@barryhughes
Copy link
Member

barryhughes commented Nov 9, 2021 •
edited
Loading

Fail under PHP 7.4 probably unrelated. Internal ref: p1636489795406100-slack-C0E1AV8T0

@barryhughes barryhughes merged commit 501d821 into woocommerce:trunk Nov 9, 2021
@github-actions github-actions bot added this to the 6.0.0 milestone Nov 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021 •
edited by barryhughes
Loading

Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the status: needs changelog label
  • Add the status: needs testing instructions label

@barryhughes barryhughes added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Nov 9, 2021
@masteradhoc masteradhoc deleted the chile-locale-informations branch November 11, 2021 16:31
@ObliviousHarmony ObliviousHarmony added changelog added and removed release: add changelog Mark all PRs that have not had their changelog entries added. [auto] labels Nov 21, 2021
@rodelgc rodelgc added testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Nov 23, 2021
@jorgeatorres jorgeatorres mentioned this pull request Sep 15, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barryhughes barryhughes barryhughes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Chile should have Regions and Commutes by default on Woo

4 participants

@masteradhoc @barryhughes @rodelgc @ObliviousHarmony